Skip to content

Conversation

@Marcono1234
Copy link
Contributor

Follow-up for #3817. The currently used query console links selected the projects gradle/gradle and eclipse-cdt/cdt which can both currently not be queried. This prevents the user to re-run the query after applying their own changes.
This pull request updates the query console links to run on all currently available demo projects.

It also fixes some minor typos and formatting issues and replaces outdated predicates in source-locations.rst.

Removes 'gradle/gradle' from the queried projects because it cannot be
queried currently, and instead queries all demo projects which are currently
available.
Removes 'eclipse-cdt/cdt' and 'gradle/gradle' from the queried projects
because they cannot be queried currently, and instead queries all demo
projects which are currently available.
Removes 'eclipse-cdt/cdt' and 'gradle/gradle' from the queried projects
because they cannot be queried currently, and instead queries all demo
projects which are currently available.
Removes 'eclipse-cdt/cdt' and 'gradle/gradle' from the queried projects
because they cannot be queried currently, and instead queries all demo
projects which are currently available.
Removes 'eclipse-cdt/cdt' and 'gradle/gradle' from the queried projects
because they cannot be queried currently, and instead queries all demo
projects which are currently available.
Removes 'gradle/gradle' from the queried projects because it cannot be
queried currently, and instead queries all demo projects which are currently
available.
…d predicates

Removes 'eclipse-cdt/cdt' and 'gradle/gradle' from the queried projects
because they cannot be queried currently, and instead queries all demo
projects which are currently available.
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for fixing all these links (and spotting the typos and deprecated predicates!)

I've found a small issue with one of the links, but otherwise this is great 😃

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this as soon as the tests pass.

@shati-patel shati-patel removed the request for review from jf205 July 6, 2020 20:10
@semmle-qlci semmle-qlci merged commit f2ce125 into github:master Jul 6, 2020
@Marcono1234 Marcono1234 deleted the fix-outdated-query-links branch July 7, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants