C++: Data flow across link targets and StmtExpr #742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test failed because of a trap importer bug that's been fixed in the internal repo now, but I think it'll fail for a different reason until #747 is merged. All of that is unrelated to this PR. |
Contributor
Author
|
@kevinbackhouse have you had a chance to test this? |
Contributor
|
@jbj: Sorry, I couldn't figure out how to test it in Eclipse. Then other things came up and I forgot about it. |
The previous join seemed to perform fine, but it displayed a 20x tuple count bulge, which could be risky for the performance on large snapshots.
Contributor
Author
|
I'll split this up into two separate PRs. |
This was referenced Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kevinbackhouse I've tested the dispatch change in QL4E on systemd, and it seems to work. We probably shouldn't merge this until I've written unit tests, but maybe you'd like to test it right away.