C++: Delete library-tests/qlcfg/cfg.ql #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was intended to catch regressions in the CFG, but it looks like it's just catching insignificant extractor changes. The test has started failing after some recent extractor changes, but I have no way to pinpoint the failure and understand whether it's a problem or not, so I think it's better to delete this test. The remaining tests check whether the QL-based CFG generates the same graph as the extractor-based CFG. Furthermore, the `successor-tests` check that the extractor-based CFG works as intended.
This was referenced Jan 11, 2019
Merged
ian-semmle
approved these changes
Jan 11, 2019
rdmarsh2
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was intended to catch regressions in the CFG, but it looks like it's just catching insignificant extractor changes. The test has started failing after some recent extractor changes, but I have no way to pinpoint the failure and understand whether it's a problem or not, so I think it's better to delete this test.
The remaining tests check whether the QL-based CFG generates the same graph as the extractor-based CFG. Furthermore, the
successor-testscheck that the extractor-based CFG works as intended.