Skip to content

[WIP] Fix the failing GitHub Actions workflow for test coverage report#1370

Merged
lpcox merged 2 commits intocopilot/fix-circular-dependency-issuefrom
copilot/fix-github-actions-workflow-please-work
Mar 19, 2026
Merged

[WIP] Fix the failing GitHub Actions workflow for test coverage report#1370
lpcox merged 2 commits intocopilot/fix-circular-dependency-issuefrom
copilot/fix-github-actions-workflow-please-work

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

  • Investigate CI failure (branch coverage regression in src/docker-manager.ts and src/cli.ts)
  • Add tests for openaiApiBasePath in api-proxy environment (lines 1204, 1271)
  • Add tests for anthropicApiBasePath in api-proxy environment (lines 1206, 1281)
  • Extend RUSTUP_HOME test to cover truthy branch at line 473
  • Add SUDO_UID/SUDO_GID NaN validation tests to cover edge cases at lines 52, 76
  • Run tests to confirm coverage regression is fixed (79.31% > 79.21% base)
  • Code review (no issues)
  • CodeQL security scan (no alerts)
  • Committed and pushed
Original prompt

Fix the failing GitHub Actions workflow Test Coverage Report
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 67792786955
Job URL: https://github.com/github/gh-aw-firewall/actions/runs/23309471747/job/67792786955


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

@lpcox lpcox marked this pull request as ready for review March 19, 2026 18:40
@lpcox lpcox requested a review from Mossaka as a code owner March 19, 2026 18:40
Copilot AI review requested due to automatic review settings March 19, 2026 18:40
@lpcox lpcox merged commit d5dcd1e into copilot/fix-circular-dependency-issue Mar 19, 2026
@lpcox lpcox deleted the copilot/fix-github-actions-workflow-please-work branch March 19, 2026 18:41
Copilot AI restored the copilot/fix-github-actions-workflow-please-work branch March 19, 2026 18:41
Copilot AI requested a review from lpcox March 19, 2026 18:41
Copilot stopped work on behalf of lpcox due to an error March 19, 2026 18:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves CI test coverage to unblock the “Test Coverage Report” GitHub Actions workflow by adding targeted unit tests for previously uncovered branches in docker-manager.

Changes:

  • Add test coverage for invalid SUDO_UID / SUDO_GID parsing paths in getSafeHostUid() and getSafeHostGid().
  • Extend chroot env passthrough test to cover RUSTUP_HOMEAWF_RUSTUP_HOME.
  • Add api-proxy env tests for OPENAI_API_BASE_PATH and ANTHROPIC_API_BASE_PATH being set/unset based on config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lpcox added a commit that referenced this pull request Mar 19, 2026
…1369)

* feat: support base path prefix for OpenAI and Anthropic API targets

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* [WIP] Fix the failing GitHub Actions workflow for test coverage report (#1370)

* Initial plan

* fix: add tests for api-base-path feature to fix coverage regression

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* test: add robust tests for API target path preservation

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix: resolve high severity flatted prototype pollution vulnerability (#1372)

* Initial plan

* fix: update flatted to 3.4.2 to resolve high severity prototype pollution vulnerability

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: Landon Cox <landon.cox@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants