fix: update vulnerable dependencies (flatted, markdownlint-cli2)#1374
fix: update vulnerable dependencies (flatted, markdownlint-cli2)#1374
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
There was a problem hiding this comment.
Pull request overview
This PR resolves an npm audit failure in CI by updating vulnerable Node.js development dependencies used by the project’s build/lint tooling.
Changes:
- Bump
markdownlint-cli2from^0.17.2to^0.21.0inpackage.json. - Refresh
package-lock.jsonto pick up patched versions (includingflatted3.4.2) and updated transitive dependencies for the markdownlint toolchain.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates the direct devDependency markdownlint-cli2 to a non-vulnerable release. |
| package-lock.json | Locks updated versions for markdownlint-cli2 and patched transitive dependencies (including flatted). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The markdownlint-cli2 v0.21.0 upgrade introduces the new MD060 (table-column-style) rule which flags 1030 existing table formatting patterns across the codebase. Disable this rule to match the project's existing table style conventions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Smoke Test Results — ✅ GitHub MCP: #1372 "fix: resolve high severity flatted prototype pollution vulnerability", #1370 "[WIP] Fix the failing GitHub Actions workflow for test coverage report" Overall: PASS
|
|
Smoke Test Results — PASS ✅ GitHub MCP: #1372 fix: resolve high severity flatted prototype pollution vulnerability, #1369 feat: support base path prefix for OpenAI and Anthropic API targets
|
Chroot Version Comparison Results
Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
🔮 The oracle records this smoke reading.
Warning
|
Summary
Fixes the
npm auditfailure in the Dependency Vulnerability Audit CI workflow (failing run).Changes
Updates two vulnerable devDependencies:
flattedparse()markdownlint-cli2Verification
npm audit --audit-level=high→ 0 vulnerabilities (was 1 high + 4 moderate)npm run build→ compiles successfullynpm test→ all 1116 tests passnpm run lint→ passesnpx markdownlint-cli2 README.md→ works with existing.markdownlint.jsonconfigSecurity Summary
No new vulnerabilities introduced. All existing high and moderate vulnerabilities have been resolved.