fix: remove sandbox.mcp.version from strict-mode workflows#2273
fix: remove sandbox.mcp.version from strict-mode workflows#2273
Conversation
The sandbox.mcp.version field is not allowed in strict mode, causing compilation to fail. Removed from smoke-services, smoke-gemini, smoke-opencode, and update-release-notes. Only sandbox.agent.version is needed (mcp version uses the compiler default). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔥 Smoke Test Results
PR: fix: remove sandbox.mcp.version from strict-mode workflows Overall: PASS
|
|
Smoke Test Results Overall Status: PASS
|
|
Smoke Test: Copilot BYOK (Offline) Mode — PASS ✅
Running in BYOK offline mode ( Overall: PASS
|
|
PRs: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
There was a problem hiding this comment.
Pull request overview
Removes the sandbox.mcp.version frontmatter key from strict-mode agentic workflow sources where it is not supported, relying instead on the strict-mode compiler default MCP gateway version.
Changes:
- Deleted
sandbox.mcp.versionfrom 4 strict-mode workflow source files. - Leaves
sandbox.agent.versionintact so the agent image remains explicitly pinned.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/update-release-notes.md | Drops sandbox.mcp.version from a strict-mode workflow source to fix strict compilation. |
| .github/workflows/smoke-services.md | Drops sandbox.mcp.version from strict-mode smoke workflow source. |
| .github/workflows/smoke-opencode.md | Drops sandbox.mcp.version from strict-mode smoke workflow source. |
| .github/workflows/smoke-gemini.md | Drops sandbox.mcp.version from strict-mode smoke workflow source. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 4
| sandbox: | ||
| agent: | ||
| version: v0.25.29 | ||
| mcp: | ||
| version: v0.3.1 | ||
| strict: true |
There was a problem hiding this comment.
This workflow’s frontmatter changed, but the corresponding generated lock file (smoke-opencode.lock.yml) isn’t updated in this PR. Please re-run gh aw compile for this .md and commit the regenerated .lock.yml so the frontmatter_hash / strict compilation output stays in sync.
| sandbox: | ||
| agent: | ||
| version: v0.25.29 | ||
| mcp: | ||
| version: v0.3.1 | ||
| strict: true |
There was a problem hiding this comment.
This workflow’s frontmatter changed, but the corresponding generated lock file (smoke-gemini.lock.yml) isn’t updated in this PR. Please re-run gh aw compile for this .md and commit the regenerated .lock.yml so the frontmatter_hash / strict compilation output stays in sync.
| sandbox: | ||
| agent: | ||
| version: v0.25.29 | ||
| mcp: | ||
| version: v0.3.1 | ||
| tools: |
There was a problem hiding this comment.
This workflow’s frontmatter changed, but the corresponding generated lock file (update-release-notes.lock.yml) isn’t updated in this PR. Please re-run gh aw compile for this .md and commit the regenerated .lock.yml so the frontmatter_hash / strict compilation output stays in sync.
| sandbox: | ||
| agent: | ||
| version: v0.25.29 | ||
| mcp: | ||
| version: v0.3.1 | ||
| strict: true |
There was a problem hiding this comment.
This workflow’s frontmatter changed, but the corresponding generated lock file (smoke-services.lock.yml) isn’t updated in this PR. Please re-run gh aw compile for this .md and commit the regenerated .lock.yml so the frontmatter_hash / strict compilation output stays in sync.
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test: Gemini Engine Validation
Overall status: PASS cc: @lpcox
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL —
|
Removes
sandbox.mcp.versionfrom 4 strict-mode workflows where it was incorrectly added (causes compilation error):smoke-services.mdsmoke-gemini.mdsmoke-opencode.mdupdate-release-notes.mdOnly
sandbox.agent.versionis needed — mcpg version uses the compiler default in strict mode.