Skip to content

Fix failing integration test: update playwright tool count and naming format#2067

Merged
lpcox merged 2 commits intofeat/difc-filtered-item-loggingfrom
copilot/fix-github-actions-workflow
Mar 17, 2026
Merged

Fix failing integration test: update playwright tool count and naming format#2067
lpcox merged 2 commits intofeat/difc-filtered-item-loggingfrom
copilot/fix-github-actions-workflow

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026

TestPlaywrightMCPServer/ToolsRegistered was failing because the test contained stale hard-coded expectations that no longer match the current mcp/playwright image behavior.

Changes

  • Tool count: Updated expected count from 2221 to match the tools the current playwright image actually registers
  • Tool name separator: Updated from triple-underscore (playwright___browser_close) → dash (playwright-browser_close) to match the current gateway naming convention
// Before
if !strings.Contains(stderrStr, "Registered 22 tools from playwright") &&
    !strings.Contains(stderrStr, "Registered tool: playwright___browser_close") {

// After
if !strings.Contains(stderrStr, "Registered 21 tools from playwright") &&
    !strings.Contains(stderrStr, "Registered tool: playwright-browser_close") {
Original prompt

Fix the failing GitHub Actions workflow integration-test
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 67483962994
Job URL: https://github.com/github/gh-aw-mcpg/actions/runs/23218086781/job/67483962994


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

…ng format (dash)

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot AI changed the title [WIP] [67483962994] Fix the failing GitHub Actions workflow integration-test Fix failing integration test: update playwright tool count and naming format Mar 17, 2026
Copilot AI requested a review from lpcox March 17, 2026 21:57
@lpcox lpcox marked this pull request as ready for review March 17, 2026 22:02
Copilot AI review requested due to automatic review settings March 17, 2026 22:02
@lpcox lpcox merged commit 589438f into feat/difc-filtered-item-logging Mar 17, 2026
@lpcox lpcox deleted the copilot/fix-github-actions-workflow branch March 17, 2026 22:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Playwright integration test’s log-based assertions so they match the current gateway logging format and the current mcp/playwright container’s tool registration behavior, fixing a failing CI integration test.

Changes:

  • Update the expected registered tool count from 22 to 21 in test log assertions.
  • Update expected tool log naming separator from ___ to - (e.g., playwright-browser_close).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +209 to +210
if !strings.Contains(stderrStr, "Registered 21 tools from playwright") &&
!strings.Contains(stderrStr, "Registered tool: playwright-browser_close") {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants