Fix failing integration test: update playwright tool count and naming format#2067
Merged
lpcox merged 2 commits intofeat/difc-filtered-item-loggingfrom Mar 17, 2026
Merged
Conversation
…ng format (dash) Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [67483962994] Fix the failing GitHub Actions workflow integration-test
Fix failing integration test: update playwright tool count and naming format
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Playwright integration test’s log-based assertions so they match the current gateway logging format and the current mcp/playwright container’s tool registration behavior, fixing a failing CI integration test.
Changes:
- Update the expected registered tool count from 22 to 21 in test log assertions.
- Update expected tool log naming separator from
___to-(e.g.,playwright-browser_close).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+209
to
+210
| if !strings.Contains(stderrStr, "Registered 21 tools from playwright") && | ||
| !strings.Contains(stderrStr, "Registered tool: playwright-browser_close") { |
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPlaywrightMCPServer/ToolsRegisteredwas failing because the test contained stale hard-coded expectations that no longer match the currentmcp/playwrightimage behavior.Changes
22→21to match the tools the current playwright image actually registersplaywright___browser_close) → dash (playwright-browser_close) to match the current gateway naming conventionOriginal prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.