Conversation
Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/9c52f71f-431d-4d06-ba30-170a7cbdd160 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tools field documentation discrepancy identified in report
Correct Apr 16, 2026
tools field documentation to match runtime allowlist enforcement
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the configuration reference to correctly describe how the per-server tools allowlist behaves at runtime, aligning docs/CONFIGURATION.md with the gateway’s current tool filtering/enforcement logic.
Changes:
- Rewords
toolsas an allowlist (not just “intended exposure”). - Documents runtime enforcement on discovery (
tools/list) and execution (tools/call). - Clarifies allow-all defaults and wildcard behavior (
["*"]/ omitted field).
Show a summary per file
| File | Description |
|---|---|
| docs/CONFIGURATION.md | Corrects tools field documentation to describe runtime allowlist semantics and defaults. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly docs reconciliation found a mismatch:
docs/CONFIGURATION.mdsaid the servertoolsfield is not enforced, but runtime already enforces it for both discovery and execution paths. This PR updates the configuration reference to reflect actual behavior and remove misleading security guidance.Documentation correction (
docs/CONFIGURATION.md)toolsfrom “intended to be exposed” to “list of tool names to allow”.tools/list403ontools/call["*"]allows all toolstoolspreserves allow-all behaviorWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com/tmp/go-build288318675/b510/launcher.test /tmp/go-build288318675/b510/launcher.test -test.testlogfile=/tmp/go-build288318675/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true g_.a -I x_amd64/vet --gdwarf-5 backoff -o x_amd64/vet -o MP1gqioUw 9853127/b288/ x_amd64/vet -p github.com/Burnt-atomic -lang=go1.18 x_amd64/vet(dns block)/tmp/go-build2484935478/b514/launcher.test /tmp/go-build2484935478/b514/launcher.test -test.testlogfile=/tmp/go-build2484935478/b514/testlog.txt -test.paniconexit0 -test.timeout=10m0s 8393�� --noprofile cfg 64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports -importcfg 64/pkg/tool/linux_amd64/vet 8393�� /tmp/go-build2998393940/b057/vet.cfg /home/REDACTED/go/pkg/mod/google.golang.org/grpc@v-ifaceassert 64/pkg/tool/linux_amd64/vet s.go s_unsafe.go ache/go/1.25.8/x-o 64/pkg/tool/linux_amd64/vet(dns block)invalid-host-that-does-not-exist-12345.com/tmp/go-build288318675/b492/config.test /tmp/go-build288318675/b492/config.test -test.testlogfile=/tmp/go-build288318675/b492/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true /sig.s elemetry.io/otel@v1.43.0/semconv/v1.40.0/doc.go x_amd64/vet --gdwarf-5 pickfirst/intern-unsafeptr=false lcache/go/1.25.8-unreachable=false x_amd64/vet -I g_.a 989853127/b288//_cgo_.o x_amd64/vet --gdwarf-5 --64 9853127/b288/ x_amd64/vet(dns block)/tmp/go-build2484935478/b496/config.test /tmp/go-build2484935478/b496/config.test -test.testlogfile=/tmp/go-build2484935478/b496/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build4184684721/b534/vet.cfg 8393940/b211/vet.cfg cfg 64/pkg/tool/linux_amd64/vet -p google.golang.org/grpc/resolver -lang=go1.24 64/pkg/tool/linux_amd64/vet 8393�� VhqIL5F_jm2QYlEh5z2z/VhqIL5F_jm2QYlEh5z2z cfg 64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports -importcfg 64/pkg/tool/linu-buildtags(dns block)nonexistent.local/tmp/go-build288318675/b510/launcher.test /tmp/go-build288318675/b510/launcher.test -test.testlogfile=/tmp/go-build288318675/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true g_.a -I x_amd64/vet --gdwarf-5 backoff -o x_amd64/vet -o MP1gqioUw 9853127/b288/ x_amd64/vet -p github.com/Burnt-atomic -lang=go1.18 x_amd64/vet(dns block)/tmp/go-build2484935478/b514/launcher.test /tmp/go-build2484935478/b514/launcher.test -test.testlogfile=/tmp/go-build2484935478/b514/testlog.txt -test.paniconexit0 -test.timeout=10m0s 8393�� --noprofile cfg 64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports -importcfg 64/pkg/tool/linux_amd64/vet 8393�� /tmp/go-build2998393940/b057/vet.cfg /home/REDACTED/go/pkg/mod/google.golang.org/grpc@v-ifaceassert 64/pkg/tool/linux_amd64/vet s.go s_unsafe.go ache/go/1.25.8/x-o 64/pkg/tool/linux_amd64/vet(dns block)slow.example.com/tmp/go-build288318675/b510/launcher.test /tmp/go-build288318675/b510/launcher.test -test.testlogfile=/tmp/go-build288318675/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true g_.a -I x_amd64/vet --gdwarf-5 backoff -o x_amd64/vet -o MP1gqioUw 9853127/b288/ x_amd64/vet -p github.com/Burnt-atomic -lang=go1.18 x_amd64/vet(dns block)/tmp/go-build2484935478/b514/launcher.test /tmp/go-build2484935478/b514/launcher.test -test.testlogfile=/tmp/go-build2484935478/b514/testlog.txt -test.paniconexit0 -test.timeout=10m0s 8393�� --noprofile cfg 64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports -importcfg 64/pkg/tool/linux_amd64/vet 8393�� /tmp/go-build2998393940/b057/vet.cfg /home/REDACTED/go/pkg/mod/google.golang.org/grpc@v-ifaceassert 64/pkg/tool/linux_amd64/vet s.go s_unsafe.go ache/go/1.25.8/x-o 64/pkg/tool/linux_amd64/vet(dns block)this-host-does-not-exist-12345.com/tmp/go-build288318675/b519/mcp.test /tmp/go-build288318675/b519/mcp.test -test.testlogfile=/tmp/go-build288318675/b519/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 9853127/b379/_pkg_.a -I x_amd64/vet --gdwarf-5 g/grpc/internal/test -o x_amd64/vet .cfg�� vETN/_26YzdEWvp07jCyovETN /tmp/go-build1989853127/b288/ x_amd64/vet . --gdwarf2 --64 x_amd64/vet(dns block)/tmp/go-build2484935478/b523/mcp.test /tmp/go-build2484935478/b523/mcp.test -test.testlogfile=/tmp/go-build2484935478/b523/testlog.txt -test.paniconexit0 -test.timeout=10m0s -uns�� /tmp/go-build299-p cfg 64/pkg/tool/linu-lang=go1.25 64/src/runtime/cgrep 1yubCdL4X .13/x64/bin/as 64/pkg/tool/linu-goversion(dns block)If you need me to access, download, or install something from one of these locations, you can either: