-
Notifications
You must be signed in to change notification settings - Fork 310
Closed
Closed
Copy link
Labels
Description
Objective
Add a clarifying code comment to pkg/styles/huh_theme.go explaining why it intentionally imports github.com/charmbracelet/lipgloss (v1) instead of the charm.land/lipgloss/v2 used elsewhere in the package.
Context
Source: discussion #22035 — Terminal Stylist console output audit.
huh_theme.go imports the v1 lipgloss package while the rest of pkg/styles/ uses v2. This is intentional — huh v0.8.0 depends on lipgloss v1, not v2 — but it isn't documented in the file, which can cause confusion.
Approach
- Open
pkg/styles/huh_theme.go - Locate the
import "github.com/charmbracelet/lipgloss"line - Add a comment immediately above (or as an inline comment) explaining the intentional v1 import:
// huh v0.8.0 depends on charmbracelet/lipgloss v1, not charm.land/lipgloss/v2.
// This file intentionally uses the v1 import to match huh's type expectations.
import "github.com/charmbracelet/lipgloss"Files to Modify
pkg/styles/huh_theme.go— add comment near the lipgloss v1 import
Acceptance Criteria
- A comment explains the intentional v1 lipgloss import in
huh_theme.go -
make buildpasses -
make lintpasses
Generated by Plan Command for issue #discussion #22035 · ◷
- expires on Mar 23, 2026, 5:17 AM UTC
Reactions are currently unavailable
Metadata
Metadata
Labels
Type
Fields
Give feedbackNo fields configured for issues without a type.