docs: explain intentional lipgloss v1 import in huh_theme.go#22100
Merged
docs: explain intentional lipgloss v1 import in huh_theme.go#22100
Conversation
4 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/21c9baae-92df-417d-ad6d-28989bf3f039
Copilot
AI
changed the title
[WIP] Add comment to huh_theme.go explaining intentional lipgloss v1 import
docs: explain intentional lipgloss v1 import in huh_theme.go
Mar 21, 2026
pelikhan
approved these changes
Mar 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Documents an intentional dependency/version mismatch in pkg/styles/huh_theme.go, clarifying why this file imports github.com/charmbracelet/lipgloss (v1) while the rest of the styles package uses charm.land/lipgloss/v2.
Changes:
- Added an inline import comment explaining that
huh v0.8.0depends on lipgloss v1 and this file must match those types.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pelikhan
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/styles/huh_theme.goimportsgithub.com/charmbracelet/lipgloss(v1) while the rest ofpkg/styles/usescharm.land/lipgloss/v2. This mismatch is intentional —huh v0.8.0depends on lipgloss v1 — but was undocumented, creating confusion.Changes
pkg/styles/huh_theme.go: Added comment above the v1 lipgloss import to document the intentional version mismatch:⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.