Skip to content

docs: explain intentional lipgloss v1 import in huh_theme.go#22100

Merged
pelikhan merged 2 commits intomainfrom
copilot/add-comment-huh-theme-go
Mar 21, 2026
Merged

docs: explain intentional lipgloss v1 import in huh_theme.go#22100
pelikhan merged 2 commits intomainfrom
copilot/add-comment-huh-theme-go

Conversation

Copy link
Contributor

Copilot AI commented Mar 21, 2026

pkg/styles/huh_theme.go imports github.com/charmbracelet/lipgloss (v1) while the rest of pkg/styles/ uses charm.land/lipgloss/v2. This mismatch is intentional — huh v0.8.0 depends on lipgloss v1 — but was undocumented, creating confusion.

Changes

  • pkg/styles/huh_theme.go: Added comment above the v1 lipgloss import to document the intentional version mismatch:
// huh v0.8.0 depends on charmbracelet/lipgloss v1, not charm.land/lipgloss/v2.
// This file intentionally uses the v1 import to match huh's type expectations.
"github.com/charmbracelet/lipgloss"

⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

Copilot AI changed the title [WIP] Add comment to huh_theme.go explaining intentional lipgloss v1 import docs: explain intentional lipgloss v1 import in huh_theme.go Mar 21, 2026
Copilot AI requested a review from pelikhan March 21, 2026 05:29
@pelikhan pelikhan marked this pull request as ready for review March 21, 2026 05:39
Copilot AI review requested due to automatic review settings March 21, 2026 05:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents an intentional dependency/version mismatch in pkg/styles/huh_theme.go, clarifying why this file imports github.com/charmbracelet/lipgloss (v1) while the rest of the styles package uses charm.land/lipgloss/v2.

Changes:

  • Added an inline import comment explaining that huh v0.8.0 depends on lipgloss v1 and this file must match those types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pelikhan pelikhan merged commit 6ea504b into main Mar 21, 2026
115 checks passed
@pelikhan pelikhan deleted the copilot/add-comment-huh-theme-go branch March 21, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[plan] Add comment to huh_theme.go explaining intentional lipgloss v1 import

3 participants