Skip to content

Fix error propagation in compiler: return errors instead of swallowing them #14301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 7, 2026
Merged

Fix error propagation in compiler: return errors instead of swallowing them #14301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9fff03
Initial plan
Copilot Feb 7, 2026
6339d83
Fix error wrapping in compiler files - return errors instead of only …
Copilot Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/workflow/compiler_activation_jobs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,9 @@ func (c *Compiler) buildActivationJob(data *WorkflowData, preActivationJobCreate
if data.SafeOutputs != nil && data.SafeOutputs.Messages != nil {
messagesJSON, err := serializeMessagesConfig(data.SafeOutputs.Messages)
if err != nil {
compilerActivationJobsLog.Printf("Warning: failed to serialize messages config for activation job: %v", err)
} else if messagesJSON != "" {
return nil, fmt.Errorf("failed to serialize messages config for activation job: %w", err)
}
if messagesJSON != "" {
steps = append(steps, fmt.Sprintf(" GH_AW_SAFE_OUTPUT_MESSAGES: %q\n", messagesJSON))
}
}
Expand Down
5 changes: 2 additions & 3 deletions pkg/workflow/compiler_yaml_main_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,9 @@ func (c *Compiler) generateMainJobSteps(yaml *strings.Builder, data *WorkflowDat
// Convert to JSON array for the script
repoImportsJSON, err := json.Marshal(data.RepositoryImports)
if err != nil {
compilerYamlLog.Printf("Warning: failed to marshal repository imports: %v", err)
} else {
fmt.Fprintf(yaml, " GH_AW_REPOSITORY_IMPORTS: '%s'\n", string(repoImportsJSON))
return fmt.Errorf("failed to marshal repository imports for merge step: %w", err)
}
fmt.Fprintf(yaml, " GH_AW_REPOSITORY_IMPORTS: '%s'\n", string(repoImportsJSON))
}

// Set agent import spec if present (legacy path)
Expand Down
Loading