Increase test coverage for compiler_jobs.go job orchestration logic

[Copilot]

Problem

Job orchestration in compiler_jobs.go had insufficient test coverage (0.47:1 ratio) with untested edge cases in dependency resolution, custom job handling, and activation dependency injection.

Changes

Added 15 test functions covering previously untested paths:

Helper function edge cases:

• referencesCustomJobOutputs with nil inputs, non-existent job references, and complex expressions
• jobDependsOnPreActivation / jobDependsOnAgent with invalid types, mixed arrays, empty needs
• getCustomJobsDependingOnPreActivation with malformed configs

Custom job scenarios:

• Multiple dependency chains (job_a → job_b → job_c with array dependencies)
• Circular dependency handling (doesn't crash, defers to GitHub Actions runtime)
• Automatic activation dependency injection for jobs without explicit needs
• Pre-activation job skipping in buildCustomJobs (both pre_activation and pre-activation variants)

Configuration variations:

• Job-level permissions (write/read combinations)
• Conditional execution (if expressions)
• Reusable workflows with with parameters and secret validation
• shouldAddCheckoutStep logic across ActionMode values (dev/release/script)

Example - Circular dependency handling:

// Compiler now handles circular deps without crashing
// (GitHub Actions catches this at runtime)
jobs:
  job_a:
    needs: job_b
  job_b:
    needs: job_a

Coverage Impact

Test/source ratio: 0.47:1 → 4.27:1 (1968 test lines vs 460 source lines)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Code Quality] Increase test coverage for compiler_jobs.go</issue_title>
<issue_description>## Description

The compiler_jobs.go file has a test/source ratio of 0.47:1 (215 test lines for 460 source lines), below the recommended 0.8:1 threshold. Complex job orchestration logic may have untested edge cases that could lead to runtime failures.

Current State

• File: pkg/workflow/compiler_jobs.go (460 lines)
• Test File: pkg/workflow/compiler_jobs_test.go (215 lines)
• Test/Source Ratio: 0.47:1 (target: 0.8:1 = ~370 test lines)
• Gap: Need ~155 additional test lines

Suggested Changes

Add comprehensive table-driven tests focusing on:

1. Custom job dependency resolution

   • Test jobs depending on pre-activation
   • Test jobs with multiple dependencies
   • Test circular dependency detection (if implemented)

2. Job ordering scenarios

   • Test correct ordering with complex dependency graphs
   • Test jobs that depend on main job
   • Test jobs that depend on detection job

3. Edge cases in special jobs

   • Test push_repo_memory job with various configurations
   • Test cache_memory job generation
   • Test custom job output references

4. Job manager state validation

   • Validate job manager state after complex builds
   • Test job manager with conflicting requirements

Example Test Structure

func TestCustomJobDependencyResolution(t *testing.T) {
    tests := []struct {
        name           string
        jobConfig      map[string]any
        expectedDeps   []string
        shouldHaveError bool
    }{
        {
            name: "job depends on pre-activation",
            jobConfig: map[string]any{
                "needs": "pre-activation",
            },
            expectedDeps: []string{"pre-activation"},
        },
        // Add more test cases
    }
    
    for _, tt := range tests {
        t.Run(tt.name, func(t *testing.T) {
            // Test implementation
        })
    }
}

Files Affected

• pkg/workflow/compiler_jobs_test.go (add ~155 lines)

Success Criteria

• Test/source ratio ≥0.8:1 (~370 total test lines)
• At least 3-5 new test functions added
• All edge cases covered with table-driven tests
• All existing tests continue to pass
• Tests include both success and error paths

Priority

Medium - Complex orchestration needs comprehensive tests to catch edge cases

Estimated Effort

2-4 hours

Source

Extracted from:

• Daily Compiler Code Quality Report - Feb 6 (#14159)

Listed as "Short-term Improvement" (Medium Priority) in compiler quality report.

AI generated by Discussion Task Miner - Code Quality Improvement Agent

• expires on Feb 7, 2026, 9:07 PM UTC

Comments on the Issue (you are @copilot in this section)

• Fixes [Code Quality] Increase test coverage for compiler_jobs.go #14232

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

Improves confidence in workflow job orchestration by adding extensive unit/integration test coverage around compiler_jobs.go helper functions and custom job handling scenarios (dependencies, reusable workflows, permissions, and activation/pre-activation behaviors).

Changes:

• Added helper-function edge case tests for custom job output references and dependency detection (needs parsing).
• Added new orchestration tests for custom job behaviors: multi-dependency chains, circular dependencies (non-crash), activation dependency injection, and pre-activation job skipping.
• Added configuration variation tests for job-level permissions, if conditions, reusable workflows (with/secrets validation), and checkout-step decisions across ActionModes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

TestBuildCustomJobsWithMultipleDependencies claims to verify that job_c depends on both job_a and job_b, but the current assertion only checks that the entire compiled YAML contains the strings job_a and job_b. Because the workflow steps echo those strings, this will pass even if the needs list is wrong/missing. Tighten this test to assert against the job_c job's needs field specifically (e.g., parse the YAML and inspect jobs.job_c.needs, or at least match a needs: block containing both entries).

[Copilot]

The test name TestBuildCustomJobsWithCircularDetection is misleading: the compiler doesn't detect or resolve circular dependencies here; the test only verifies it doesn't crash and that both jobs get added. Consider renaming to something like TestBuildCustomJobsWithCircularDependencyDoesNotCrash (or similar) to better reflect what is being validated.

Suggested change

	// TestBuildCustomJobsWithCircularDetection tests handling of circular dependencies
	func TestBuildCustomJobsWithCircularDetection(t *testing.T) {
	// TestBuildCustomJobsWithCircularDependencyDoesNotCrash ensures circular dependencies don't crash compilation
	func TestBuildCustomJobsWithCircularDependencyDoesNotCrash(t *testing.T) {