[WIP] Fix failing GitHub Actions workflow runtime and setup#14796
Conversation
Update the test expectation to use the current SHA for actions/setup-node@v6.2.0 (6044e13b5dc448c55e2357c09f80417699197238) instead of the outdated SHA (395ad3262231945c25e8478fd5baf05154b1d79f). The action_pins.json file was recently updated with newer action SHAs, and this test needed to be synchronized. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the workflow runtime/setup integration test to align its expected pinned actions/setup-node@v6 SHA with the current value in action_pins.json, fixing a failing integration test in the workflow compiler/runtime setup area.
Changes:
- Updated the expected
actions/setup-nodepinned SHA inTestRuntimeSetupIntegrationto the current pin.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| expectSetup: []string{ | ||
| "Setup Node.js", | ||
| "actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f", | ||
| "actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238", | ||
| "node-version: '24'", | ||
| }, |
There was a problem hiding this comment.
This test still hard-codes the pinned actions/setup-node SHA, which is what caused the failure when action_pins.json was updated. To avoid future breakage, consider deriving the expected SHA from the same source as the compiler (e.g., GetActionPinByRepo("actions/setup-node") and asserting on "actions/setup-node@"+pin.SHA, or using GetActionPin("actions/setup-node") and checking it’s present in the lock content). This would keep the integration test automatically in sync with pin updates (same applies to the other hard-coded action SHAs in this file).
* updated pins * [WIP] Fix integration tests for updated pins (#14791) * Initial plan * Initial plan for fixing integration tests Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Update integration tests with new action pins Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * [WIP] Fix failing GitHub Actions workflow Integration: Workflow Compiler (#14792) * Initial plan * Update action pin SHAs in runtime integration tests Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * [WIP] Fix failing GitHub Actions workflow runtime and setup (#14796) * Initial plan * Fix TestRuntimeSetupIntegration by updating setup-node SHA Update the test expectation to use the current SHA for actions/setup-node@v6.2.0 (6044e13b5dc448c55e2357c09f80417699197238) instead of the outdated SHA (395ad3262231945c25e8478fd5baf05154b1d79f). The action_pins.json file was recently updated with newer action SHAs, and this test needed to be synchronized. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add retry logic for transient GitHub API errors in live integration test (#14799) * Initial plan * Add retry logic for transient GitHub API errors in frontmatter hash test Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Address code review feedback: extract retry config constants and scope core mock Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fix Integration Test: Workflow Runtime & Setup
Root Cause
The
TestRuntimeSetupIntegrationtest was failing because it expected an outdated SHA foractions/setup-node@v6:395ad3262231945c25e8478fd5baf05154b1d79f6044e13b5dc448c55e2357c09f80417699197238(fromaction_pins.json)The
action_pins.jsonfile was recently updated with newer action SHAs, but the integration test wasn't updated to match.Implementation Plan
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.