Skip to content

[WIP] Fix failing GitHub Actions workflow runtime and setup #14796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 10, 2026
Merged

[WIP] Fix failing GitHub Actions workflow runtime and setup #14796

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
446d7d1
Initial plan
Copilot Feb 10, 2026
c0ce454
Fix TestRuntimeSetupIntegration by updating setup-node SHA
Copilot Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/workflow/runtime_setup_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ steps:
# Test workflow`,
expectSetup: []string{
"Setup Node.js",
"actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f",
"actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238",
"node-version: '24'",
},
Comment on lines 51 to 55
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test still hard-codes the pinned actions/setup-node SHA, which is what caused the failure when action_pins.json was updated. To avoid future breakage, consider deriving the expected SHA from the same source as the compiler (e.g., GetActionPinByRepo("actions/setup-node") and asserting on "actions/setup-node@"+pin.SHA, or using GetActionPin("actions/setup-node") and checking it’s present in the lock content). This would keep the integration test automatically in sync with pin updates (same applies to the other hard-coded action SHAs in this file).

Copilot uses AI. Check for mistakes.
},
Expand Down
Loading