Remove TestGetActionPinSemverPreference test

[Copilot]

TestGetActionPinSemverPreference failed because the action pins dataset contained actions/upload-artifact@v6 but the test expected v6.0.0. Rather than maintaining patch-level pins for semver preference validation, the test is removed.

Changes

• Removed TestGetActionPinSemverPreference from pkg/workflow/action_pins_test.go (55 lines)
• Other action pin tests (TestGetActionPinWithData_SemverPreference, TestGetActionPinByRepo) remain and continue to validate version resolution behavior

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/graphql
  • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw ply.github.com> (http block)
  • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name ache/node/24.13.0/x64/bin/node se 5192707/b191/vetcheckout ache/go/1.25.0/x.github/workflows/test.md git estl�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet ache/node/24.13.0/x64/bin/node copilot/fix-uplogit (http block)
  • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name ache/node/24.13.0/x64/bin/node k/gh-aw/gh-aw/pkgit (http block)
• https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
  • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha pkg/workflow/data/action_pins.json git 0/x64/bin/node nner/work/gh-aw/git x_amd64/vet e/git 0/x64/bin/node -o /tmp/go-build1765729558/b389/_pkg_.a -trimpath 64/bin/bash -p main -lang=go1.25 gh (http block)
• https://api.github.com/repos/actions/checkout/git/ref/tags/v3
  • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha 3625-15054/test-2241153354/.github/workflows /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet 0/x64/bin/node rkflow/js/**/*.jgit -buildtags erignore sh ash.�� vaScript4270846557/001/test-empty-frontmatter.md-test.timeout=10m0s git ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet ./../.prettieriggit -tests /usr/bin/git ache/go/1.25.0/x64/pkg/tool/linuconfig (http block)
• https://api.github.com/repos/actions/checkout/git/ref/tags/v4
  • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha rd (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha runs/20260216-103625-15054/test--errorsas git 5729558/b357/vet.cfg ettierignore (http block)
• https://api.github.com/repos/actions/checkout/git/ref/tags/v5
  • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha celain --ignore-submodules | head -n 10 --local ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet http.https://gitgit (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha -unreachable=false /tmp/go-build3135192707/b044/vet.cfg ad-artifact-pin-test (http block)
• https://api.github.com/repos/actions/github-script/git/ref/tags/v8
  • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha rd (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -c=4 -nolocalimports -importcfg /tmp/go-build1765729558/b123/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/cmd/gh-aw/main.go /home/REDACTED/work/gh-aw/gh-aw/cmd/gh-aw/capitalization_test.go rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git (http block)
• https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
  • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha runs/20260216-103625-15054/test--errorsas git /home/REDACTED/node_modules/.bin/n-nilfunc l (http block)
• https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
  • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha (http block)
  • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha "prettier" --write 'scripts/**/*-errorsas git 5729558/b375/vet.cfg ettierignore (http block)
• https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
  • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 ache/go/1.25.0/x64/pkg/tool/linumain ache/node/24.13.0/x64/bin/node se 5192707/b229/vet-unsafeptr=false ache/go/1.25.0/x-unreachable=false git estl�� --show-toplevel /bin/sh ache/node/24.13.0/x64/bin/node f() { test "$1" git f() { test "$1" rev-parse tnet/tools/bash git (http block)
• https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
  • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 ortcfg ache/node/24.13.0/x64/bin/node path.sh' '/usr/bgit g/workflow/imporrev-parse ache/go/1.25.0/x--show-toplevel git _inc�� '**/*.ts' '**/*.json' --ignore-path ../../../.prettierignore ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet h -v origin ache/go/1.25.0/x--show-toplevel git (http block)
• https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
  • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 ache/go/1.25.0/x64/pkg/tool/linu-ifaceassert ache/node/24.13.0/x64/bin/node path.sh' '' && egit 5192707/b227/vetrev-parse ache/go/1.25.0/x--show-toplevel git _har�� '**/*.ts' '**/*.json' --ignore-premote.origin.url ache/go/1.25.0/x64/pkg/tool/linux_amd64/compile bin/sh 5192707/b339/_pkgit origin bin/bash git (http block)
• https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
  • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 ache/go/1.25.0/x64/pkg/tool/linu-w ache/node/24.13.0/x64/bin/node se 5192707/b212/vetrev-parse ache/node/24.13.--show-toplevel git estl�� --show-toplevel /bin/sh ache/node/24.13.0/x64/bin/node f() { test "$1" git f() { test "$1" rev-parse bash git (http block)
• https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
  • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 ache/go/1.25.0/x64/pkg/tool/linu-ifaceassert x_amd64/compile se 5192707/b231/vetrev-parse k/_temp/ghcca-no--show-toplevel x_amd64/compile 0/x6�� --show-toplevel bash ache/node/24.13.0/x64/bin/node --noprofile (http block)
• https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
  • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 ache/go/1.25.0/x64/pkg/tool/linu-test.run=^Test x_amd64/compile se 5192707/b232/vetrev-parse /opt/hostedtoolc--show-toplevel x_amd64/compile 0/x6�� --show-toplevel bash ndor/bin/sh --noprofile (http block)
• https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
  • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 ache/go/1.25.0/x64/pkg/tool/linu-test.run=^Test 64/bin/node se 5192707/b234/vetrev-parse cal/bin/bash git 0/x6�� --show-toplevel bash ache/node/24.13.0/x64/bin/node --noprofile (http block)
• https://api.github.com/repos/github/gh-aw/actions/workflows
  • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --show-toplevel 9280aabf08554fe4**/*.json /usr/bin/git (http block)
  • Triggering command: `/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 requested

Co-au-atomic 64/pkg/tool/linu-bool git /pre�� --show-toplevel 64/pkg/tool/linu-ifaceassert 0/x64/bin/node` (http block)

• Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 5192707/b196/vetreset ache/go/1.25.0/xHEAD git 0/x6�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet 8d519d9/node_modules/.bin/prettier se 5192707/b061/vetrev-parse /opt/hostedtoolc--show-toplevel git (http block)
• https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
  • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha (http block)
  • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha 2241153354/.github/workflows ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet k/gh-aw/gh-aw/node_modules/.bin/sh son /tmp/go-build313remote /opt/hostedtoolc-v node js/f�� 57/001/test-empty-frontmatter.md-test.timeout=10m0s /opt/hostedtoolcache/go/1.25.0/x-test.run=^Test 64/pkg/tool/linux_amd64/vet nore -buildtags 2064633/b123/vet/tmp/gh-aw-test-runs/20260216-103625-15054/test-1130782109 64/pkg/tool/linuconfig (http block)
• https://api.github.com/repos/nonexistent/repo/actions/runs/12345
  • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion --noprofile (http block)
• https://api.github.com/repos/owner/repo/actions/workflows
  • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo /usr/bin/git (http block)
  • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo modules/@npmcli/run-script/lib/node-gyp-bin/node (http block)
  • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state ache/node/24.13.0/x64/bin/node copilot/fix-uplogit (http block)
• https://api.github.com/repos/test-owner/test-repo/actions/secrets
  • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name --show-toplevel x_amd64/vet /usr/bin/git (http block)
• https://api.github.com/user
  • Triggering command: /usr/bin/gh gh api user --jq .login --show-toplevel x_amd64/vet /usr/bin/git n:::' && echo "$npx (http block)
  • Triggering command: /usr/bin/gh gh api user --jq .login --show-toplevel x_amd64/vet /usr/bin/git (http block)
  • Triggering command: /usr/bin/gh gh api user --jq .login '**/*.ts' '**/*.-c=4 ache/go/1.25.0/x-nolocalimports ache/node/24.13.-importcfg git status --porgit (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[CI Failure Doctor] Missing upload-artifact@v6.0.0 pin breaks action pin tests</issue_title>
<issue_description># 🏥 CI Failure Investigation - Run github/gh-aw#22058525578

Summary

TestGetActionPinSemverPreference fails because the newly added action pin dataset only provides an actions/upload-artifact@v6 entry, so GetActionPin returns # v6 where the test asserts that the highest semver pin should read v6.0.0.

Failure Details

• Run: 22058525578
• Commit: 50cc1f9
• Trigger: push

Root Cause Analysis

pkg/workflow/data/action_pins.json (and the matching .github/aw/actions-lock.json) only recorded actions/upload-artifact pins for v4.6.2, v5, and v6. TestGetActionPinSemverPreference expects the highest semver for this repo to be v6.0.0, so GetActionPin and GetActionPinByRepo currently resolve to the v6 entry, which causes the assertions to fail.

Failed Jobs and Errors

• test – action_pins_test.go:576 and action_pins_test.go:585 report:

  GetActionPin(actions/upload-artifact) = actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6, expected version v6.0.0
  GetActionPinByRepo(actions/upload-artifact).Version = v6, expected v6.0.0
  

Investigation Findings

1. The embedded JSON for action pins lacked an actions/upload-artifact@v6.0.0 entry, so the semver selection code picked the v6 pin it could see.
2. The workflow action lock mirrored the same dataset, so no downstream workflows knew about the patch-level tag either.
3. Without the v6.0.0 release object, the semver preference test can't identify the expected version and fails before any workflow generation begins.

Recommended Actions

• Add an actions/upload-artifact@v6.0.0 entry (same SHA b7c566a772e6b6bfb58ed0dc250532a479d7789f) to both pkg/workflow/data/action_pins.json and .github/aw/actions-lock.json so the semver-sorting helpers now resolve to v6.0.0.
• Re-run go test ./pkg/workflow -run TestGetActionPinSemverPreference (or the full test job) after the environments that run locally can download the Go 1.25 toolchain to confirm the fix before reverting to the CI run.

Prevention Strategies

When updating action pin datasets, always verify that the patch-level tags expected by TestGetActionPinSemverPreference and other semver-aware tests exist in both embedded JSONs. Consider adding a quick script/check that cross-references the highest semver tag for each repo with the entries currently stored so such mismatches are caught before a CI run.

AI Team Self-Improvement

Before touching the action pin lists, remind the AI agent to ensure (1) the desired patch-level version (e.g., v6.0.0) is present in pkg/workflow/data/action_pins.json and .github/aw/actions-lock.json, and (2) TestGetActionPinSemverPreference will therefore still pass with the new data.

Historical Context

No previous CI Failure Doctor investigation has documented this exact failure; the problem appeared when the new action pin dataset was introduced without that v6.0.0 entry.

🩺 Diagnosis provided by CI Failure Doctor

To install this workflow, run gh aw add githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d. View source at https://github.com/githubnext/agentics/tree/ea350161ad5dcc9624cf510f134c6a9e39a6f94d/workflows/ci-doctor.md.

• expires on Feb 17, 2026, 10:22 AM UTC

Comments on the Issue (you are @copilot in this section)

@pelikhan Delete this test.

• Fixes [CI Failure Doctor] Missing upload-artifact@v6.0.0 pin breaks action pin tests #16082

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR removes a brittle test that was failing due to mismatched version expectations between the test and the action pins dataset. The maintainer chose to delete the test rather than maintain patch-level version pins.

Changes:

• Removed TestGetActionPinSemverPreference test function (55 lines) from pkg/workflow/action_pins_test.go

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.