Skip to content

Remove TestGetActionPinSemverPreference test #16084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 16, 2026
Merged

Remove TestGetActionPinSemverPreference test #16084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ff504
Initial plan
Copilot Feb 16, 2026
fe8ed40
Remove TestGetActionPinSemverPreference test as requested
Copilot Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions pkg/workflow/action_pins_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,61 +533,6 @@ func TestApplyActionPinToTypedStep_Immutability(t *testing.T) {
}
}

// TestGetActionPinSemverPreference verifies that when multiple versions exist for the same repo,
// the latest version by semver is returned
func TestGetActionPinSemverPreference(t *testing.T) {
tests := []struct {
name string
repo string
expectedVersion string
}{
{
name: "setup-go prefers v6.2.0 over v6",
repo: "actions/setup-go",
expectedVersion: "v6.2.0",
},
{
name: "setup-node prefers v6.2.0 over v6",
repo: "actions/setup-node",
expectedVersion: "v6.2.0",
},
{
name: "upload-artifact prefers v6.0.0 over v5 and v4",
repo: "actions/upload-artifact",
expectedVersion: "v6.0.0",
},
{
name: "setup-python prefers v5.6.0 over v5",
repo: "actions/setup-python",
expectedVersion: "v5.6.0",
},
{
name: "cache prefers v4.3.0 over v4",
repo: "actions/cache",
expectedVersion: "v4.3.0",
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Test GetActionPin
result := GetActionPin(tt.repo)
if !strings.Contains(result, "# "+tt.expectedVersion) {
t.Errorf("GetActionPin(%s) = %s, expected version %s", tt.repo, result, tt.expectedVersion)
}

// Test GetActionPinByRepo
pin, exists := GetActionPinByRepo(tt.repo)
if !exists {
t.Fatalf("GetActionPinByRepo(%s) returned false, expected true", tt.repo)
}
if pin.Version != tt.expectedVersion {
t.Errorf("GetActionPinByRepo(%s).Version = %s, expected %s", tt.repo, pin.Version, tt.expectedVersion)
}
})
}
}

// TestGetActionPinWithData_SemverPreference tests that GetActionPinWithData
// resolves actions using the exact version tag specified, and only falls back
// to compatible versions when the exact tag doesn't exist in hardcoded pins
Expand Down