fix(perf): hoist regexp.MustCompile outside loop in validateExpressionForDangerousProps#20070
Closed
JasonOA888 wants to merge 1 commit intogithub:mainfrom
Closed
fix(perf): hoist regexp.MustCompile outside loop in validateExpressionForDangerousProps#20070JasonOA888 wants to merge 1 commit intogithub:mainfrom
JasonOA888 wants to merge 1 commit intogithub:mainfrom
Conversation
6434e2c to
502aa1d
Compare
Fixes github#20026 Problem: - validateExpressionForDangerousProps called regexp.MustCompile twice - One call was inside a for loop (per-iteration allocation) - This is called for every expression in every compiled workflow - Regex allocations accumulated significantly in hot path Solution: - Added exprPartSplitRe and exprNumericPartRe as package-level vars - These are compiled once at init time, not per-call/iteration - Replaced inline MustCompile calls with references to these vars Impact: - Eliminates repeated regex compilation in expression validation - Reduces allocations in hot path - No behavior change, pure performance optimization
502aa1d to
7598346
Compare
Contributor
|
Please contribution guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20026
Problem
Two
regexp.MustCompilecalls invalidateExpressionForDangerousProps:regexp.MustCompile("[.\\[\\]]+")- called per function invocationregexp.MustCompile("^\\d+$")- called inside for loop, per iterationSince
validateSingleExpressionis recursive and called for every expression in every compiled workflow, these allocations accumulate significantly.Solution
Hoist both regex patterns to package-level
vardeclarations alongside existing regex vars:Replace inline
MustCompilecalls with references to these pre-compiled patterns.Impact
Reported in discussion #19993 (Sergo audit).