Skip to content

fix(perf): hoist regexp.MustCompile outside loop in validateExpressionForDangerousProps #20070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JasonOA888 wants to merge 1 commit into from
Closed

fix(perf): hoist regexp.MustCompile outside loop in validateExpressionForDangerousProps #20070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/workflow/expression_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ var (
stringLiteralRegex = regexp.MustCompile(`^'[^']*'$|^"[^"]*"$|^` + "`[^`]*`$")
// numberLiteralRegex matches integer and decimal number literals (with optional leading minus)
numberLiteralRegex = regexp.MustCompile(`^-?\d+(\.\d+)?$`)

// exprPartSplitRe splits expressions on dots and brackets (e.g., "github.event.issue" -> ["github", "event", "issue"])
// Used in validateExpressionForDangerousProps to parse property access patterns
exprPartSplitRe = regexp.MustCompile(`[.\[\]]+`)
// exprNumericPartRe matches numeric indices (e.g., "0" in "assets[0]")
// Used to filter out array indices when checking for dangerous property names
exprNumericPartRe = regexp.MustCompile(`^\d+$`)
)

// validateExpressionSafety checks that all GitHub Actions expressions in the markdown content
Expand Down Expand Up @@ -209,11 +216,11 @@ func validateExpressionForDangerousProps(expression string) error {
// Split expression into parts handling both dot notation (e.g., "github.event.issue")
// and bracket notation (e.g., "release.assets[0].id")
// Filter out numeric indices (e.g., "0" in "assets[0]")
parts := regexp.MustCompile(`[.\[\]]+`).Split(trimmed, -1)
parts := exprPartSplitRe.Split(trimmed, -1)

for _, part := range parts {
// Skip empty parts and numeric indices
if part == "" || regexp.MustCompile(`^\d+$`).MatchString(part) {
if part == "" || exprNumericPartRe.MatchString(part) {
continue
}

Expand Down
Loading