Skip to content

fix(lint): remove unused secretNamePattern variable#20735

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-lint-issues-go
Mar 13, 2026
Merged

fix(lint): remove unused secretNamePattern variable#20735
pelikhan merged 2 commits intomainfrom
copilot/fix-lint-issues-go

Conversation

Copy link
Contributor

Copilot AI commented Mar 13, 2026

golangci-lint (unused) was failing on pkg/workflow/secrets_validation.go due to a declared but unreferenced package-level variable.

  • Removed var secretNamePattern = regexp.MustCompile(...) from secrets_validation.go — the pattern was never used within the file or package; a similarly-named (but distinct) pattern in pkg/stringutil/sanitize.go is unaffected
Original prompt

Fix lint go https://github.com/github/gh-aw/actions/runs/23026473329/job/66875357067


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix lint issues in Go code fix(lint): remove unused secretNamePattern variable Mar 13, 2026
Copilot AI requested a review from pelikhan March 13, 2026 00:23
@pelikhan pelikhan marked this pull request as ready for review March 13, 2026 00:24
Copilot AI review requested due to automatic review settings March 13, 2026 00:24
@pelikhan pelikhan merged commit 2e14ff5 into main Mar 13, 2026
@pelikhan pelikhan deleted the copilot/fix-lint-issues-go branch March 13, 2026 00:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused, package-level regex variable that was causing golangci-lint (unused) failures in the workflow secrets validation code.

Changes:

  • Deleted the unreferenced secretNamePattern regexp.MustCompile(...) variable from pkg/workflow/secrets_validation.go.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants