Skip to content

fix(lint): remove unused secretNamePattern variable #20735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 13, 2026
Merged

fix(lint): remove unused secretNamePattern variable #20735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96033a9
Initial plan
Copilot Mar 13, 2026
cca43af
fix lint: remove unused secretNamePattern variable
Copilot Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/workflow/secrets_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ var secretsValidationLog = newValidationLogger("secrets")
// This is the same pattern used in the github_token schema definition ($defs/github_token).
var secretsExpressionPattern = regexp.MustCompile(`^\$\{\{\s*secrets\.[A-Za-z_][A-Za-z0-9_]*(\s*\|\|\s*secrets\.[A-Za-z_][A-Za-z0-9_]*)*\s*\}\}$`)

// secretNamePattern validates that a secret name follows environment variable naming conventions
var secretNamePattern = regexp.MustCompile(`^[A-Z][A-Z0-9_]*$`)

// validateSecretsExpression validates that a value is a proper GitHub Actions secrets expression.
// Returns an error if the value is not in the format: ${{ secrets.NAME }} or ${{ secrets.NAME || secrets.NAME2 }}
// Note: This function intentionally does not accept the secret key name as a parameter to prevent
Expand Down
Loading