deps: update github.com/modelcontextprotocol/go-sdk v1.4.0 → v1.4.1 (security patch)#21221
deps: update github.com/modelcontextprotocol/go-sdk v1.4.0 → v1.4.1 (security patch)#21221
Conversation
….4.1 (security patch) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
There was a problem hiding this comment.
Pull request overview
Updates the MCP Go SDK dependency to pick up upstream security fixes (including the transitive segmentio/encoding patch) and associated HTTP transport hardening.
Changes:
- Bump
github.com/modelcontextprotocol/go-sdkfromv1.4.0tov1.4.1 - Bump transitive
github.com/segmentio/encodingfromv0.5.3tov0.5.4 - Refresh
go.sumchecksums accordingly
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates required module versions for the MCP Go SDK and its transitive security-fix dependency. |
| go.sum | Updates dependency checksums to match the new versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| github.com/goccy/go-yaml v1.19.2 | ||
| github.com/google/jsonschema-go v0.4.2 | ||
| github.com/modelcontextprotocol/go-sdk v1.4.0 | ||
| github.com/modelcontextprotocol/go-sdk v1.4.1 |
There was a problem hiding this comment.
Noted! The origin validation change is worth testing specifically with the MCP inspector flow. Good catch on the Streamable HTTP behavior changes.
📰 BREAKING: Report filed by Smoke Copilot
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
|
Commit pushed:
|
Smoke Test: Codex Engine Validation
References: §23144378014
Warning
|
|
Smoke Test §23144377962 —
Overall: ✅ PASS
|
There was a problem hiding this comment.
Dependency update looks clean. Two deps updated (go-sdk v1.4.1 security patch + transitive segmentio/encoding v0.5.4). LGTM.
📰 BREAKING: Report filed by Smoke Copilot
| github.com/goccy/go-yaml v1.19.2 | ||
| github.com/google/jsonschema-go v0.4.2 | ||
| github.com/modelcontextprotocol/go-sdk v1.4.0 | ||
| github.com/modelcontextprotocol/go-sdk v1.4.1 |
There was a problem hiding this comment.
Good security patch update for go-sdk v1.4.0 → v1.4.1. Keeping MCP dependencies up-to-date is important given this is a security patch.
| github.com/sahilm/fuzzy v0.1.1 // indirect | ||
| github.com/segmentio/asm v1.1.3 // indirect | ||
| github.com/segmentio/encoding v0.5.3 // indirect | ||
| github.com/segmentio/encoding v0.5.4 // indirect |
There was a problem hiding this comment.
Transitive dependency segmentio/encoding also bumped (v0.5.3 → v0.5.4) as a result of this update — looks like an expected cascade.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
Smoke test results — Run §23144378045
Overall: PARTIAL (15 ✅, 2
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude
| github.com/sahilm/fuzzy v0.1.1 // indirect | ||
| github.com/segmentio/asm v1.1.3 // indirect | ||
| github.com/segmentio/encoding v0.5.3 // indirect | ||
| github.com/segmentio/encoding v0.5.4 // indirect |
There was a problem hiding this comment.
The segmentio/encoding bump (v0.5.3 → v0.5.4) is a transitive dependency update alongside the MCP SDK upgrade. Good to see indirect dependencies kept in sync.
| github.com/modelcontextprotocol/go-sdk v1.4.0 h1:u0kr8lbJc1oBcawK7Df+/ajNMpIDFE41OEPxdeTLOn8= | ||
| github.com/modelcontextprotocol/go-sdk v1.4.0/go.mod h1:Nxc2n+n/GdCebUaqCOhTetptS17SXXNu9IfNTaLDi1E= | ||
| github.com/modelcontextprotocol/go-sdk v1.4.1 h1:M4x9GyIPj+HoIlHNGpK2hq5o3BFhC+78PkEaldQRphc= | ||
| github.com/modelcontextprotocol/go-sdk v1.4.1/go.mod h1:Bo/mS87hPQqHSRkMv4dQq1XCu6zv4INdXnFZabkNU6s= |
There was a problem hiding this comment.
Hash verified for github.com/modelcontextprotocol/go-sdk v1.4.1. Security patch looks clean.
Security patch release for
go-sdkthat fixes a JSON parsing attack vector viasegmentio/encodingand adds cross-origin request protection for HTTP Streamable MCP servers.Changes
github.com/modelcontextprotocol/go-sdkv1.4.0 → v1.4.1github.com/segmentio/encodingv0.5.3 → v0.5.4 (transitive; the actual security fix)Notable behavior changes in v1.4.1
POSTrequests now requireContent-Type: application/jsonhttp.CrossOriginProtectionvalidates request origins on HTTP Streamable serversdisablecrossoriginprotectiondebug knob is available if compatibility issues arise✨ PR Review Safe Output Test - Run 23144223396
✨ PR Review Safe Output Test - Run 23144378045