Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/minor-remove-defaults-schema.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions docs/src/content/docs/reference/frontmatter-full.md
Original file line number Diff line number Diff line change
Expand Up @@ -620,20 +620,6 @@ permissions:
# (optional)
run-name: "example-value"

# Default settings that will apply to all jobs in the workflow
# (optional)
defaults:
# Default shell and working directory
# (optional)
run:
# Default shell for run steps
# (optional)
shell: "example-value"

# Default working directory for run steps
# (optional)
working-directory: "example-value"

# Groups together all the jobs that run in the workflow
# (optional)
jobs:
Expand Down
2 changes: 1 addition & 1 deletion pkg/constants/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ var PriorityStepFields = []string{"name", "id", "if", "run", "uses", "script", "

// PriorityJobFields defines the conventional field order for GitHub Actions workflow jobs
// Fields appear in this order first, followed by remaining fields alphabetically
var PriorityJobFields = []string{"name", "runs-on", "needs", "if", "permissions", "environment", "concurrency", "outputs", "env", "defaults", "steps"}
var PriorityJobFields = []string{"name", "runs-on", "needs", "if", "permissions", "environment", "concurrency", "outputs", "env", "steps"}

// PriorityWorkflowFields defines the conventional field order for top-level GitHub Actions workflow frontmatter
// Fields appear in this order first, followed by remaining fields alphabetically
Expand Down
26 changes: 0 additions & 26 deletions pkg/parser/schema_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -723,32 +723,6 @@ func TestValidateMainWorkflowFrontmatterWithSchema(t *testing.T) {
},
wantErr: false,
},
{
name: "valid GitHub Actions defaults property",
frontmatter: map[string]any{
"on": "push",
"defaults": map[string]any{
"run": map[string]any{
"shell": "bash",
"working-directory": "/app",
},
},
},
wantErr: false,
},
{
name: "invalid defaults with additional properties",
frontmatter: map[string]any{
"defaults": map[string]any{
"run": map[string]any{
"shell": "bash",
"invalid_prop": "value",
},
},
},
wantErr: true,
errContains: "additional properties 'invalid_prop' not allowed",
},
{
name: "valid claude engine with network permissions",
frontmatter: map[string]any{
Expand Down
25 changes: 0 additions & 25 deletions pkg/parser/schemas/main_workflow_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1070,28 +1070,6 @@
"type": "string",
"description": "Custom name for workflow runs that appears in the GitHub Actions interface (supports GitHub expressions like ${{ github.event.issue.title }})"
},
"defaults": {
"type": "object",
"description": "Default settings that will apply to all jobs in the workflow",
"additionalProperties": false,
"properties": {
"run": {
"type": "object",
"description": "Default shell and working directory",
"additionalProperties": false,
"properties": {
"shell": {
"type": "string",
"description": "Default shell for run steps"
},
"working-directory": {
"type": "string",
"description": "Default working directory for run steps"
}
}
}
}
},
"jobs": {
"type": "object",
"description": "Groups together all the jobs that run in the workflow",
Expand Down Expand Up @@ -1194,9 +1172,6 @@
"type": "string"
}
},
"defaults": {
"$ref": "#/properties/defaults"
},
"concurrency": {
"$ref": "#/properties/concurrency"
}
Expand Down
Loading