-
Notifications
You must be signed in to change notification settings - Fork 312
fix: ensure githubnext/agentics resolves to github.com when GHE is configured #22014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9aab44b
chore: outline GHE fix plan for githubnext/agentics
Copilot e441fae
fix: ensure githubnext/agentics always resolves to github.com in GHE …
Copilot 60a7874
fix: only pin githubnext/agentics to github.com when GHE is configured
Copilot 15e3f36
Merge branch 'main' into copilot/update-agentics-url-for-ghe
pelikhan 321e9e2
fix: address review comments - centralize host pinning, add tests, fi…
Copilot ef7cdd1
Merge branch 'main' into copilot/update-agentics-url-for-ghe
pelikhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getGitHubHostForRepo now treats githubnext/agentics as always hosted on public GitHub, but there are no unit tests covering this function (pkg/cli/github_test.go only tests getGitHubHost). Add tests that set GH_HOST to a GHE host and verify getGitHubHostForRepo("githubnext/agentics") (and prefixed paths) returns constants.PublicGitHubHost while non-allowlisted repos return the configured enterprise host.