fix: use <strong> instead of ** bold in <summary> elements#22377
Merged
fix: use <strong> instead of ** bold in <summary> elements#22377
<strong> instead of ** bold in <summary> elements#22377Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/a8d8fd71-1c0f-4161-93bb-3aef83a42852
Copilot created this pull request from a session on behalf of
pelikhan
March 23, 2026 04:37
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the firewall warning <summary> text rendering as literal Markdown (e.g., **...**) by switching to HTML <strong> so the summary is actually bold when rendered.
Changes:
- Update
generateBlockedDomainsSection()to use<strong>inside the<summary>instead of**...**. - Update Vitest assertions to match the new HTML output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| actions/setup/js/firewall_blocked_domains.cjs | Replaces Markdown bold syntax with <strong> within the <summary> HTML for correct rendering. |
| actions/setup/js/firewall_blocked_domains.test.cjs | Updates expected strings to assert against the new <strong>-wrapped summary content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown
**bold**syntax is not processed inside HTML elements, so the firewall warning summary rendered as literal**⚠️ Firewall blocked 2 domains**instead of bold text.Changes
firewall_blocked_domains.cjs: Replace**...**with<strong>...</strong>in the<summary>tagfirewall_blocked_domains.test.cjs: Update assertions to match new HTML output