Skip to content

fix: use <strong> instead of ** bold in <summary> elements#22377

Merged
pelikhan merged 1 commit intomainfrom
copilot/fix-markdown-syntax-firewall-action
Mar 23, 2026
Merged

fix: use <strong> instead of ** bold in <summary> elements#22377
pelikhan merged 1 commit intomainfrom
copilot/fix-markdown-syntax-firewall-action

Conversation

Copy link
Contributor

Copilot AI commented Mar 23, 2026

Markdown **bold** syntax is not processed inside HTML elements, so the firewall warning summary rendered as literal **⚠️ Firewall blocked 2 domains** instead of bold text.

Changes

  • firewall_blocked_domains.cjs: Replace **...** with <strong>...</strong> in the <summary> tag
  • firewall_blocked_domains.test.cjs: Update assertions to match new HTML output
- section += `> <summary>**⚠️ Firewall blocked ${domainCount} ${domainWord}**</summary>\n`;
+ section += `> <summary><strong>⚠️ Firewall blocked ${domainCount} ${domainWord}</strong></summary>\n`;

@pelikhan pelikhan marked this pull request as ready for review March 23, 2026 04:37
Copilot AI review requested due to automatic review settings March 23, 2026 04:37
@pelikhan pelikhan merged commit 06885de into main Mar 23, 2026
50 checks passed
@pelikhan pelikhan deleted the copilot/fix-markdown-syntax-firewall-action branch March 23, 2026 04:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the firewall warning <summary> text rendering as literal Markdown (e.g., **...**) by switching to HTML <strong> so the summary is actually bold when rendered.

Changes:

  • Update generateBlockedDomainsSection() to use <strong> inside the <summary> instead of **...**.
  • Update Vitest assertions to match the new HTML output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
actions/setup/js/firewall_blocked_domains.cjs Replaces Markdown bold syntax with <strong> within the <summary> HTML for correct rendering.
actions/setup/js/firewall_blocked_domains.test.cjs Updates expected strings to assert against the new <strong>-wrapped summary content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants