Skip to content

fix: use <strong> instead of ** bold in <summary> elements #22377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Mar 23, 2026
+3 −3
Merged

fix: use <strong> instead of ** bold in <summary> elements #22377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/setup/js/firewall_blocked_domains.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ function generateBlockedDomainsSection(blockedDomains) {

let section = "\n\n> [!WARNING]\n";
section += `> <details>\n`;
section += `> <summary>**⚠️ Firewall blocked ${domainCount} ${domainWord}**</summary>\n`;
section += `> <summary><strong>⚠️ Firewall blocked ${domainCount} ${domainWord}</strong></summary>\n`;
section += `>\n`;
section += `> The following ${domainWord} ${domainCount === 1 ? "was" : "were"} blocked by the firewall during workflow execution:\n`;
section += `>\n`;
Expand Down
4 changes: 2 additions & 2 deletions actions/setup/js/firewall_blocked_domains.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ describe("firewall_blocked_domains.cjs", () => {
expect(result).toContain("> [!WARNING]");
expect(result).toContain("> <details>");
expect(result).toContain("> </details>");
expect(result).toContain("> <summary>**⚠️ Firewall blocked 1 domain**</summary>");
expect(result).toContain("> <summary><strong>⚠️ Firewall blocked 1 domain</strong></summary>");
expect(result).toContain("> - `blocked.example.com`");
expect(result).toContain("> The following domain was blocked by the firewall during workflow execution:");
expect(result).toContain('> ```yaml\n> network:\n> allowed:\n> - defaults\n> - "blocked.example.com"\n> ```');
Expand All @@ -325,7 +325,7 @@ describe("firewall_blocked_domains.cjs", () => {
expect(result).toContain("> [!WARNING]");
expect(result).toContain("> <details>");
expect(result).toContain("> </details>");
expect(result).toContain("> <summary>**⚠️ Firewall blocked 3 domains**</summary>");
expect(result).toContain("> <summary><strong>⚠️ Firewall blocked 3 domains</strong></summary>");
expect(result).toContain("> - `alpha.example.com`");
expect(result).toContain("> - `beta.example.com`");
expect(result).toContain("> - `gamma.example.com`");
Expand Down
Loading