perf: fix double regex pass in UnquoteYAMLKey causing ~2x compile slowdown

[Copilot]

BenchmarkCompileMemoryUsage regressed +103.7% (6.4ms → 13.1ms) due to UnquoteYAMLKey performing two regex operations per match: ReplaceAllStringFunc to iterate matches, then FindStringSubmatch inside the callback to retrieve capture groups. This function is called 10+ times per compilation via extractTopLevelYAMLSection.

Change

Replace the two-pass approach with ReplaceAllString using capture group references — a single-pass operation:

// Before: two regex passes per match
return re.ReplaceAllStringFunc(yamlStr, func(match string) string {
    submatches := re.FindStringSubmatch(match) // ← redundant second pass
    return submatches[1] + submatches[2] + key + ":"
})

// After: one pass
return re.ReplaceAllString(yamlStr, "${1}${2}"+key+":")

Benchmark after fix: ~7.6ms (restored to near historical baseline of ~6.4ms).

Testing

Added BenchmarkUnquoteYAMLKey to pkg/workflow/yaml_test.go to guard against future regressions of the double regex pass pattern. The benchmark uses a realistic workflow YAML string and confirms the single-pass implementation performance.

---

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

[pelikhan]

@copilot add tests

[Copilot]

@copilot add tests

Added BenchmarkUnquoteYAMLKey to pkg/workflow/yaml_test.go (commit 17d774e). It benchmarks the single-pass ReplaceAllString implementation on a realistic workflow YAML, providing a regression guard for the double-pass antipattern this PR fixes.

[Copilot]

Pull request overview

Improves workflow compilation performance by eliminating a redundant second regex pass in UnquoteYAMLKey, and adds a benchmark to track the regression going forward.

Changes:

• Refactor UnquoteYAMLKey to use ReplaceAllString with capture group references (single regex pass).
• Add BenchmarkUnquoteYAMLKey to measure/track UnquoteYAMLKey performance over realistic input.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
pkg/workflow/yaml.go	Switches UnquoteYAMLKey to a single-pass ReplaceAllString implementation to reduce compile-time overhead.
pkg/workflow/yaml_test.go	Adds a benchmark covering the UnquoteYAMLKey hot path to help detect future performance regressions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

regexp.Regexp.ReplaceAllString treats $ in the replacement string as a capture-group expansion. Since key is concatenated directly into the replacement, keys containing $ (e.g. user-provided frontmatter keys) would be corrupted by unintended backref expansion. Escape $ in key before building the replacement (e.g. replace $ with $$), or use an API that performs literal insertion for the dynamic portion.

Suggested change

	// Use ReplaceAllString with capture group references for a single-pass replacement.
	// ${1} = line start (^ or \n), ${2} = optional whitespace
	return re.ReplaceAllString(yamlStr, "${1}${2}"+key+":")
	// Escape '$' in the key so it is treated literally in the replacement string,
	// not as a backreference marker by regexp.ReplaceAllString.
	escapedKey := strings.ReplaceAll(key, "$", "$$")
	// Use ReplaceAllString with capture group references for a single-pass replacement.
	// ${1} = line start (^ or \n), ${2} = optional whitespace
	return re.ReplaceAllString(yamlStr, "${1}${2}"+escapedKey+":")