fix: add Node.js 24 runtime to daily-multi-device-docs-tester#23464
fix: add Node.js 24 runtime to daily-multi-device-docs-tester#23464
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0abdcd84-d439-476f-a31b-a4f9706c70b0 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0abdcd84-d439-476f-a31b-a4f9706c70b0 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds an explicit Node.js runtime configuration to the daily-multi-device-docs-tester workflow so it no longer defaults to Node 20 (and remains compatible with Astro 6.x).
Changes:
- Added
runtimes.node.version: "24"to.github/workflows/daily-multi-device-docs-tester.md. - Recompiled
.github/workflows/daily-multi-device-docs-tester.lock.ymlto includeactions/setup-nodewith Node 24. - Minor lockfile-only updates adding a “Friendly format” schedule comment in a few other workflow lockfiles.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/daily-multi-device-docs-tester.md | Declares Node.js 24 runtime in workflow frontmatter. |
| .github/workflows/daily-multi-device-docs-tester.lock.yml | Adds setup-node for Node 24, plus regenerated prompt/config blocks. |
| .github/workflows/slide-deck-maintainer.lock.yml | Adds a schedule “Friendly format” comment. |
| .github/workflows/dictation-prompt.lock.yml | Adds a schedule “Friendly format” comment. |
| .github/workflows/daily-copilot-token-report.lock.yml | Adds a schedule “Friendly format” comment. |
Comments suppressed due to low confidence (1)
.github/workflows/slide-deck-maintainer.lock.yml:35
- PR description says the changes are limited to the daily-multi-device-docs-tester workflow, but this PR also modifies other workflow lock files (e.g., this file). Please either update the PR description to include these additional changes or split them into a separate PR to keep the change focused.
# Friendly format: daily (scattered)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "on": | ||
| schedule: | ||
| - cron: "0 11 * * 1-5" | ||
| # Friendly format: daily (scattered) |
There was a problem hiding this comment.
The newly added # Friendly format: daily (scattered) comment conflicts with the fixed cron schedule (0 11 * * 1-5, weekdays at 11:00 UTC). Please adjust the friendly-format comment to match the actual cron (weekdays at a fixed time) to avoid confusion.
| # Friendly format: daily (scattered) | |
| # Friendly format: weekdays at 11:00 UTC |
| "on": | ||
| schedule: | ||
| - cron: "0 16 * * 1-5" | ||
| # Friendly format: daily (scattered) |
There was a problem hiding this comment.
The newly added # Friendly format: daily (scattered) comment is misleading here: the cron (0 16 * * 1-5) is a fixed weekday schedule, not a scattered daily schedule. Please update the friendly-format comment to match the actual cron (e.g., weekdays at 16:00 UTC) or omit it for non-daily schedules.
This issue also appears on line 35 of the same file.
| # Friendly format: daily (scattered) | |
| # Friendly format: weekdays at 16:00 UTC |
| "on": | ||
| schedule: | ||
| - cron: "0 6 * * 0" | ||
| # Friendly format: daily (scattered) |
There was a problem hiding this comment.
The added # Friendly format: daily (scattered) comment does not match the cron (0 6 * * 0), which is weekly (Sundays). Please correct the friendly-format annotation to reflect the weekly schedule or remove it for this workflow.
| # Friendly format: daily (scattered) | |
| # Friendly format: weekly on Sundays at 06:00 (UTC) |
| - name: Setup Node.js | ||
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version: '24' | ||
| package-manager-cache: false |
There was a problem hiding this comment.
This new Setup Node.js step appears redundant because the same job already runs another Setup Node.js step later (around line 354) with the same version. Keeping both increases runtime and maintenance overhead; prefer a single setup-node step in the job (usually right before the first npm/node usage).
| - name: Setup Node.js | |
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | |
| with: | |
| node-version: '24' | |
| package-manager-cache: false |
daily-multi-device-docs-testerwas missing aruntimes.nodedeclaration, causing the runner to default to Node.js 20 — incompatible with Astro 6.x (>=22.12.0required). This burned ~57 agent turns per run finding a working toolchain, vs. the expected ~20.Changes
.github/workflows/daily-multi-device-docs-tester.md— addedruntimes: node: version: "24"(Node 24, per reviewer guidance;docs-noob-tester.mdalready had an equivalent block).github/workflows/daily-multi-device-docs-tester.lock.yml— recompiled; now emitsactions/setup-nodewithnode-version: '24'Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw cfg 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git sm-opt >/dev/nulgit Th7M/T3k6sXHdFWprev-parse ache/go/1.25.0/x--show-toplevel git(http block)https://api.github.com/orgs/test-owner/actions/secrets/usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile(http block)https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1/usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha user.email test@example.com /usr/bin/git g_.a hema-go@v0.4.2/jrev-parse x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/gh g_.a KUOBv9MSU x_amd64/vet gh(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v3/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha t0 k/gh-aw/gh-aw/pkg/logger/logger.go(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v5/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha 8449909/b108/_pkg_.a cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 8449909/b229/_pkg_.a VV49/5VjYwczRvry0X7OSVV49 64/pkg/tool/linux_amd64/compile GOINSECURE contextprotocol/rev-parse GOMODCACHE 64/pkg/tool/linux_amd64/compile(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha list --json /usr/bin/git --workflow nonexistent-workrev-parse --limit git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git gUqI3lS-N cfg 64/pkg/tool/linu--show-toplevel git(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --show-toplevel yQm7JrG_JTdGyVRlef/N6GE9dzJuLpfUe9tz4e_/ThKvzodBlPIPkS6j74YO /usr/bin/git 3908-30619/test-git 563643/b255/vet.rev-parse _.a git rev-�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linu-buildtags 0/x64/bin/node /tmp/go-build134git -trimpath /opt/hostedtoolc--show-toplevel git(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v6/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha /tmp/TestHashStability_SameInputSameOutput734235248/001/stabilit-p x_amd64/compile /usr/bin/git -template-expresgit GO111MODULE x_amd64/vet git add .github/workflows/test.md x_amd64/vet /usr/bin/git -json GO111MODULE x_amd64/vet git(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha /tmp/file-tracker-test2074684656/test1.md /tmp/file-tracker-test2074684656/test2.lock.yml /usr/bin/git -json GO111MODULE x_amd64/vet git conf�� --get remote.origin.url /usr/bin/git g_.a GO111MODULE x_amd64/vet git(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git /tmp/go-build134git k/gh-aw/gh-aw/pkrev-parse ache/go/1.25.0/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git se 563643/b265/vet.rev-parse ache/go/1.25.0/x--show-toplevel git(http block)https://api.github.com/repos/actions/github-script/git/ref/tags/v8/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE ternal/boring/siTest User(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json .go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile(http block)https://api.github.com/repos/actions/setup-go/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha /tmp/TestCompileErrorFormatting3569722245/001 rev-parse /usr/bin/git -json GO111MODULE x_amd64/vet git -C /tmp/gh-aw-test-runs/20260329-143908-30619/test-1431199980 rev-parse /opt/hostedtoolcache/node/24.14.0/x64/bin/node @{u} GO111MODULE x_amd64/vet node(http block)https://api.github.com/repos/actions/setup-node/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha /tmp/TestHashStability_SameInputSameOutput734235248/001/stabilit-errorsas x_amd64/compile /usr/bin/git -json GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /opt/hostedtoolcache/node/24.14.0/x64/bin/node g_.a GO111MODULE x_amd64/vet node(http block)https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq .object.sha runs/20260329-143908-30619/test-4148795526/.github/workflows -buildtags 563643/b408/vet.cfg -errorsas -ifaceassert -nilfunc /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -uns�� k/gh-aw/gh-aw/.github/workflows /tmp/go-build697563643/b283/vet.cfg ache/node/24.14.0/x64/bin/node -json GO111MODULE 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linu--json(http block)https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2/usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq .object.sha /tmp/TestHashStability_SameInputSameOutput734235248/001/stability-test.md x_amd64/compile /usr/bin/git -json GO111MODULE x_amd64/vet git -C /tmp/gh-aw-test-runs/20260329-143908-30619/test-1431199980 status /usr/bin/git .github/workflowgit GO111MODULE x_amd64/vet git(http block)https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0/usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq .object.sha jpq_JbW5I -buildtags /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -errorsas -ifaceassert -nilfunc rtcfg -uns�� g/timeutil/format.go g/timeutil/format_test.go ache/go/1.25.0/x64/pkg/tool/linux_amd64/compile -json GO111MODULE 64/bin/go ache/go/1.25.0/x64/pkg/tool/linux_amd64/compile(http block)https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3/usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq .object.sha 3908-30619/test-1431199980 /tmp/go-build697563643/b160/vet.cfg 563643/b415/vet.cfg "prettier" --chegit node 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -ato�� -bool -buildtags 563643/b450/testutil.test -errorsas -ifaceassert -nilfunc 563643/b450/testutil.test(http block)https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts/usr/bin/gh gh run download 1 --dir test-logs/run-1 g/tty/tty_wasm.go x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet ortc�� 8449909/b105/_pkg_.a cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuremote.origin.url(http block)https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts/usr/bin/gh gh run download 12345 --dir test-logs/run-12345 65gtyzUS- 64/pkg/tool/linu-buildmode=exe GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu-extld=gcc env ortcfg cfg 64/pkg/tool/linux_amd64/vet a/action_pins.jsgit GOMOD GOMODCACHE 64/pkg/tool/linuTest User(http block)https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts/usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE x_amd64/compile GOINSECURE skIa0q-gzw-IzV3Prev-parse 64/src/math/big/--show-toplevel 0XVD7GS/mRL0tEU7JbrieQ94-F8q env g_.a cfg 64/pkg/tool/linux_amd64/vet GOINSECURE 8449909/b087/ GOMODCACHE 64/pkg/tool/linutest@example.com(http block)https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts/usr/bin/gh gh run download 2 --dir test-logs/run-2 om/modelcontextprotocol/go-sdk@v1.4.1/oauthex/oauthex.go 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet ortc�� 8449909/b163/_pkg_.a cfg 64/pkg/tool/linux_amd64/vet GOINSECURE g/x/crypto/cryptrev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts/usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linutest@example.com ortc�� 8449909/b106/_pkg_.a cfg 64/pkg/tool/linux_amd64/vet GOINSECURE l GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts/usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet ortc�� 8449909/b117/_pkg_.a g/console/accessibility.go 64/pkg/tool/linux_amd64/vet GOINSECURE b/gh-aw/pkg/typerev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts/usr/bin/gh gh run download 5 --dir test-logs/run-5 g/types/doc.go 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet ortc�� BBRVgf-GF cfg 64/pkg/tool/linux_amd64/vet GOINSECURE contextprotocol/init GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/actions/workflows/usr/bin/gh gh workflow list --json name,state,path cli/install.sh..." GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile(http block)/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet(http block)/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq .object.sha --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git xjry-XMFu ortcfg 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linutest@example.com /usr/bin/git 8449909/b051/_pksed om/modelcontextps/-$// 64/pkg/tool/linux_amd64/vet git(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha RHWPMZAE3 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet ortc�� 8449909/b102/_pkg_.a rg/x/text@v0.35.0/internal/stringset/set.go 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE util GOMODCACHE x_amd64/vet(http block)/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet(http block)/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json 1.4.1/mcp/client-ifaceassert x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet(http block)https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999/usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha y-test.md cfg At,event,headBranch,headSha,displayTitle GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet ortc�� edOutput2491894274/001 rg/x/text@v0.35.0/internal/language/compact/comp-ifaceassert 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuremote.origin.url(http block)https://api.github.com/repos/nonexistent/repo/actions/runs/12345/usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 3236288015/.github/workflows GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE b/gh-aw/pkg/slic/tmp/test-expr-3243305974.js GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)https://api.github.com/repos/owner/repo/actions/workflows/usr/bin/gh gh workflow list --json name,state,path --repo owner/repo x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile(http block)https://api.github.com/repos/owner/repo/contents/file.md/tmp/go-build697563643/b404/cli.test /tmp/go-build697563643/b404/cli.test -test.testlogfile=/tmp/go-build697563643/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile(http block)https://api.github.com/repos/test-owner/test-repo/actions/secrets/usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.