fix: remove observability/OTLP import from smoke-claude and smoke-copilot workflows#25481
fix: remove observability/OTLP import from smoke-claude and smoke-copilot workflows#25481
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/a06eead1-3baa-4772-a653-514a126a078e Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
❌ Tool validation failed! Agent Container Smoke Test detected missing tools: failed |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
There was a problem hiding this comment.
Pull request overview
Removes the OpenTelemetry/OTLP observability import from the smoke-claude workflow to unblock workflow compilation/execution.
Changes:
- Dropped
shared/observability-otlp.mdfrom.github/workflows/smoke-claude.mdimports. - Recompiled the lock file to remove OTLP env/config, masking steps, and OTLP-related secrets/outputs.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-claude.md | Removes the OTLP/observability import from the workflow source. |
| .github/workflows/smoke-claude.lock.yml | Updates compiled workflow to eliminate OTLP env vars, secrets, and summary/masking steps tied to OTLP. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
|
📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident... |
|
@copilot remove OpenTelemetry from smoke-copilot |
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
Note
🔒 Integrity filter blocked 1 item
The following item were blocked because they don't meet the GitHub integrity level.
- #25481
pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
To allow these resources, lower min-integrity in your GitHub frontmatter:
tools:
github:
min-integrity: approved # merged | approved | unapproved | none💥 [THE END] — Illustrated by Smoke Claude · ● 318.6K
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d5df6881-6d3c-43d3-b1ca-2243a1876316 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
❌ Tool validation failed! Agent Container Smoke Test detected missing tools: failed |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
Smoke Test Results — Run §24194655401 Core (#1–12): ✅✅✅✅✅✅✅✅✅✅✅✅ Overall: PARTIAL (2 skipped — no threads/no safe PR to close, all others ✅)
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude · ● 352.1K
| @@ -34,7 +34,6 @@ imports: | |||
| with: | |||
| packages: | |||
There was a problem hiding this comment.
Good cleanup! Removing the observability-otlp import should fix the smoke test failures caused by the missing/incompatible OTLP configuration. This aligns with the recent fix in the companion commits.
| packages: | ||
| - microsoft/apm-sample-package | ||
| - shared/observability-otlp.md | ||
| network: |
There was a problem hiding this comment.
The network.allowed: defaults section remains intact after removing the OTLP import — this is correct behavior. The network permissions are not dependent on the observability import.
|
🤖 Smoke test §24194655398 results for
Overall: ✅ PASS
|
There was a problem hiding this comment.
Smoke test review: This PR removes the shared/observability-otlp.md import from smoke workflows and recompiles all lock files. The change is a clean fix — removes OTEL-related secrets from the manifests and resolves the opentelemetry.headers schema mismatch causing smoke test failures. Lock file updates are consistent with the import removal.
📰 BREAKING: Report filed by Smoke Copilot · ● 1.1M
| @@ -34,7 +34,6 @@ imports: | |||
| with: | |||
There was a problem hiding this comment.
Removing shared/observability-otlp.md import — this simplifies the smoke workflow by dropping the OTLP observability overlay. Makes sense given the current MCP Gateway opentelemetry.headers schema mismatch that has been causing failures.
| @@ -1,5 +1,5 @@ | |||
| # gh-aw-metadata: {"schema_version":"v3","frontmatter_hash":"8c919d4d189d89a25094a830d0ae686a84c24c007f73bc2604ba92601bcf9702","agent_id":"copilot"} | |||
| # gh-aw-manifest: {"version":1,"secrets":["COPILOT_GITHUB_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GH_AW_OTEL_ENDPOINT","GH_AW_OTEL_HEADERS","GITHUB_TOKEN"],"actions":[{"repo":"actions/cache/restore","sha":"668228422ae6a00e4ad889ee87cd7109ec5666a7","version":"v5.0.4"},{"repo":"actions/cache/save","sha":"668228422ae6a00e4ad889ee87cd7109ec5666a7","version":"v5.0.4"},{"repo":"actions/checkout","sha":"de0fac2e4500dabe0009e67214ff5f5447ce83dd","version":"v6.0.2"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"ed597411d8f924073f98dfc5c65a23a2325f34cd","version":"v8"},{"repo":"actions/setup-go","sha":"4a3601121dd01d1626a1e23e37211e3254c1c06c","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"bbbca2ddaa5d8feaa63e36b76fdaad77386f024f","version":"v7"},{"repo":"docker/build-push-action","sha":"d08e5c354a6adb9ed34480a06d141179aa583294","version":"v7"},{"repo":"docker/setup-buildx-action","sha":"4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd","version":"v4"}]} | |||
| # gh-aw-metadata: {"schema_version":"v3","frontmatter_hash":"85e815a13493326e0726c3b3f2b58f133a0cee65a5a8718932928defeed64ccc","agent_id":"copilot"} | |||
There was a problem hiding this comment.
The manifest hash and secrets list updates look correct — GH_AW_OTEL_ENDPOINT and GH_AW_OTEL_HEADERS are no longer needed after dropping the OTLP import. Clean compile artifact update.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Removes the OpenTelemetry observability integration from the
smoke-claudeandsmoke-copilotworkflows per @pelikhan's request.Changes
.github/workflows/smoke-claude.md: Removed- shared/observability-otlp.mdfrom theimportssection.github/workflows/smoke-claude.lock.yml: Recompiled to reflect the removed import.github/workflows/smoke-copilot.md: Removed- shared/observability-otlp.mdfrom theimportssection.github/workflows/smoke-copilot.lock.yml: Recompiled to reflect the removed import✨ PR Review Safe Output Test - Run 24194655401