Skip to content

Run daily AstroStyleLite spellcheck unconditionally by removing invalid activation gate#27340

Merged
pelikhan merged 3 commits intomainfrom
copilot/investigate-spellcheck-issue
Apr 20, 2026
Merged

Run daily AstroStyleLite spellcheck unconditionally by removing invalid activation gate#27340
pelikhan merged 3 commits intomainfrom
copilot/investigate-spellcheck-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

The daily AstroStyleLite spellcheck workflow was skipping the spellcheck job, so the core scan never executed. The skip was caused by an if condition referencing a non-existent activation output (activated).

  • Root cause

    • spellcheck was gated by needs.activation.outputs.activated == 'true'.
    • This workflow’s activation job does not emit activated, so the condition evaluated false and the job was skipped.
  • Workflow change

    • Removed the invalid job-level gate from spellcheck in the source workflow markdown.
    • Kept downstream gating intact (agent still depends on spellcheck.outputs.has_findings == 'true'), so only agent execution remains conditional.
  • Compiled workflow sync

    • Recompiled lock file to reflect the source workflow change.
# before
spellcheck:
  needs: [activation]
  if: needs.activation.outputs.activated == 'true'

# after
spellcheck:
  needs: [activation]

Copilot AI and others added 3 commits April 20, 2026 05:58
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review April 20, 2026 12:35
Copilot AI review requested due to automatic review settings April 20, 2026 12:35
@pelikhan pelikhan merged commit f3154e8 into main Apr 20, 2026
3 checks passed
@pelikhan pelikhan deleted the copilot/investigate-spellcheck-issue branch April 20, 2026 12:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the daily AstroStyleLite markdown spellcheck workflow so the spellcheck job actually runs by removing an invalid if gate that referenced a non-existent needs.activation.outputs.activated output.

Changes:

  • Removed the job-level if: needs.activation.outputs.activated == 'true' gate from the spellcheck job in the source workflow markdown.
  • Synced the compiled workflow lock file to reflect the source workflow change.
Show a summary per file
File Description
.github/workflows/daily-astrostylelite-markdown-spellcheck.md Removes the invalid spellcheck activation gate so the spellcheck job is no longer skipped.
.github/workflows/daily-astrostylelite-markdown-spellcheck.lock.yml Regenerates the compiled workflow to remove the same invalid if condition in the lock file.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants