Fix Codex GH_AW_MCP_CONFIG to use final writable config.toml#27946
Fix Codex GH_AW_MCP_CONFIG to use final writable config.toml#27946
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6c2c85e9-3c30-4978-a569-1bc906496049 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot recompile |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/067bb563-69fe-46bc-a2c7-7f05a5b93298 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Recompiled and pushed the workflow lock files in commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
|
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🚀 Smoke OpenCode MISSION COMPLETE! OpenCode delivered. 🔥 |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
|
Agent Container Tool Check
Result: 11/12 tools available — FAIL (dotnet missing)
|
|
@copilot make sure that the generated config.toml support_websockets = false See codex output 2026-04-23T03:07:27.2284807Z ##[group]Run set -eo pipefail |
|
🤖 Smoke test agent checked in! All systems go for PR #27946.
Overall: PASS ✅
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Smoke test review of PR #27946: Fix looks correct — replacing ${{ runner.temp }} with /tmp/gh-aw/mcp-config/config.toml ensures the Codex MCP config path is accessible inside the AWF sandbox. The source fix in codex_engine.go propagates cleanly to all regenerated lock files.
📰 BREAKING: Report filed by Smoke Copilot · ● 939.4K
| CODEX_API_KEY: ${{ secrets.CODEX_API_KEY || secrets.OPENAI_API_KEY }} | ||
| CODEX_HOME: /tmp/gh-aw/mcp-config | ||
| GH_AW_MCP_CONFIG: ${{ runner.temp }}/gh-aw/mcp-config/config.toml | ||
| GH_AW_MCP_CONFIG: /tmp/gh-aw/mcp-config/config.toml |
There was a problem hiding this comment.
✅ Good fix: using /tmp/gh-aw/mcp-config/config.toml directly instead of $\{\{ runner.temp }} ensures the path works inside the AWF chroot sandbox where RUNNER_TEMP is mounted read-only.
| // Tag the step as a GitHub AW agentic execution for discoverability by agents | ||
| "GITHUB_AW": "true", | ||
| "GH_AW_MCP_CONFIG": "${{ runner.temp }}/gh-aw/mcp-config/config.toml", | ||
| "GH_AW_MCP_CONFIG": "/tmp/gh-aw/mcp-config/config.toml", |
There was a problem hiding this comment.
The source code change in codex_engine.go is the right place to fix this — all the .lock.yml regenerations flow from here. Clean and consistent fix across all workflow files.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
💥 Smoke Test Run §24814468033 — PARTIAL Core tests #1–12: ✅✅✅ ❌ ✅✅✅✅✅ ❌ ✅✅ ❌ Test 4 (Make build) — MCP timeout · ❌ Test 10 (AW MCP status) — tool error
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal! This PR correctly fixes the GH_AW_MCP_CONFIG path for Codex execution, ensuring the MCP config is written to a consistent writable location. — Run 24814468033
💥 [THE END] — Illustrated by Smoke Claude · ● 155.9K
| CODEX_API_KEY: ${{ secrets.CODEX_API_KEY || secrets.OPENAI_API_KEY }} | ||
| CODEX_HOME: /tmp/gh-aw/mcp-config | ||
| GH_AW_MCP_CONFIG: ${{ runner.temp }}/gh-aw/mcp-config/config.toml | ||
| GH_AW_MCP_CONFIG: /tmp/gh-aw/mcp-config/config.toml |
There was a problem hiding this comment.
✅ Good fix! Using /tmp/gh-aw/mcp-config/config.toml (hardcoded path) instead of $\{\{ runner.temp }}/gh-aw/mcp-config/config.toml ensures the MCP config path is consistent and writable, which is essential for Codex to retain supports_websockets = false. Smoke test review comment — Run 24814468033.
| CODEX_API_KEY: ${{ secrets.CODEX_API_KEY || secrets.OPENAI_API_KEY }} | ||
| CODEX_HOME: /tmp/gh-aw/mcp-config | ||
| GH_AW_MCP_CONFIG: ${{ runner.temp }}/gh-aw/mcp-config/config.toml | ||
| GH_AW_MCP_CONFIG: /tmp/gh-aw/mcp-config/config.toml |
There was a problem hiding this comment.
✅ Consistent change — the /tmp/gh-aw/mcp-config/config.toml path is correctly propagated here as well. Ensures all Codex-based workflows use the same writable config path. Smoke test review comment — Run 24814468033.
|
@copilot add assertion in code that the flag is present in the final config.toml file |
|
|
|
|
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/837f082f-9826-456a-a736-90c1d1035168 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated and pushed in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot the proper spelling is |
|
Summary
GH_AW_MCP_CONFIGfor Codex execution to/tmp/gh-aw/mcp-config/config.tomlsupport_websockets = falseValidation
go test -v -run "TestCodexEngineExecutionIncludesGitHubAWPrompt|TestCodexEngineExecutionUsesWritableCodexHome|TestCodexEngineRenderMCPConfigOpenAIProxyProvider" ./pkg/workflow/make recompilemake agent-finishparallel_validation(Code Review + CodeQL)