Skip to content

Fix Codex GH_AW_MCP_CONFIG to use final writable config.toml #27946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix Codex GH_AW_MCP_CONFIG to use final writable config.toml #27946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45025cd
Point Codex GH_AW_MCP_CONFIG to final writable config path
Copilot Apr 23, 2026
8506949
Plan recompile lock workflows for Codex config path change
Copilot Apr 23, 2026
5aca72a
Use support_websockets key in generated Codex config
Copilot Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ai-moderator.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/changeset.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/codex-github-remote-mcp-test.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/daily-fact.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/daily-observability-report.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/duplicate-code-detector.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/grumpy-reviewer.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/issue-arborist.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/schema-feature-coverage.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/smoke-call-workflow.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/smoke-codex.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/workflow/codex_engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ mkdir -p "$CODEX_HOME/logs"
"GH_AW_PROMPT": "/tmp/gh-aw/aw-prompts/prompt.txt",
// Tag the step as a GitHub AW agentic execution for discoverability by agents
"GITHUB_AW": "true",
"GH_AW_MCP_CONFIG": "${{ runner.temp }}/gh-aw/mcp-config/config.toml",
"GH_AW_MCP_CONFIG": "/tmp/gh-aw/mcp-config/config.toml",
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source code change in codex_engine.go is the right place to fix this — all the .lock.yml regenerations flow from here. Clean and consistent fix across all workflow files.

// Keep Codex runtime state in /tmp/gh-aw because ${RUNNER_TEMP}/gh-aw is
// mounted read-only inside the AWF chroot sandbox.
"CODEX_HOME": "/tmp/gh-aw/mcp-config",
Expand Down
4 changes: 2 additions & 2 deletions pkg/workflow/codex_engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func TestCodexEngineExecutionIncludesGitHubAWPrompt(t *testing.T) {
if strings.Contains(stepContent, "GH_AW_PROMPT: /tmp/gh-aw/aw-prompts/prompt.txt") {
foundPromptEnv = true
}
if strings.Contains(stepContent, "GH_AW_MCP_CONFIG: ${{ runner.temp }}/gh-aw/mcp-config/config.toml") {
if strings.Contains(stepContent, "GH_AW_MCP_CONFIG: /tmp/gh-aw/mcp-config/config.toml") {
foundMCPConfigEnv = true
}
}
Expand Down Expand Up @@ -337,7 +337,7 @@ func TestCodexEngineRenderMCPConfigOpenAIProxyProvider(t *testing.T) {
"name = \"OpenAI AWF proxy\"",
fmt.Sprintf("base_url = \"http://%s:%d\"", constants.AWFAPIProxyContainerIP, constants.ClaudeLLMGatewayPort),
"env_key = \"OPENAI_API_KEY\"",
"supports_websockets = false",
"support_websockets = false",
}

for _, expected := range expectedLines {
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/codex_mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func (e *CodexEngine) renderOpenAIProxyProviderToml(yaml *strings.Builder, inden
yaml.WriteString(indent + "name = \"" + codexOpenAIProxyProviderName + "\"\n")
yaml.WriteString(indent + "base_url = \"" + e.getOpenAIProxyProviderBaseURL() + "\"\n")
yaml.WriteString(indent + "env_key = \"OPENAI_API_KEY\"\n")
yaml.WriteString(indent + "supports_websockets = false\n")
yaml.WriteString(indent + "support_websockets = false\n")
}

func (e *CodexEngine) getOpenAIProxyProviderBaseURL() string {
Expand Down
Loading