Skip to content

[WIP] Fix inconsistent logging guard in error constructors #27990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 23, 2026
+6 −2
Merged

[WIP] Fix inconsistent logging guard in error constructors #27990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ad9cba
Initial plan
Copilot Apr 23, 2026
9e1ed9b
fix(workflow): guard debug logs in error constructors
Copilot Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/workflow/workflow_errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ func (e *WorkflowValidationError) Error() string {

// NewValidationError creates a new validation error with context
func NewValidationError(field, value, reason, suggestion string) *WorkflowValidationError {
errorHelpersLog.Printf("Creating validation error: field=%s, reason=%s", field, reason)
if errorHelpersLog.Enabled() {
errorHelpersLog.Printf("Creating validation error: field=%s, reason=%s", field, reason)
}
return &WorkflowValidationError{
Field: field,
Value: value,
Expand Down Expand Up @@ -168,7 +170,9 @@ func (e *ConfigurationError) Error() string {

// NewConfigurationError creates a new configuration error with context
func NewConfigurationError(configKey, value, reason, suggestion string) *ConfigurationError {
errorHelpersLog.Printf("Creating configuration error: configKey=%s, reason=%s", configKey, reason)
if errorHelpersLog.Enabled() {
errorHelpersLog.Printf("Creating configuration error: configKey=%s, reason=%s", configKey, reason)
}
return &ConfigurationError{
ConfigKey: configKey,
Value: value,
Expand Down
Loading