[WIP] Fix inconsistent logging guard in error constructors#27990
Merged
[WIP] Fix inconsistent logging guard in error constructors#27990
Conversation
3 tasks
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0832ebeb-db42-49e2-a960-ee5e146d9b63 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
approved these changes
Apr 23, 2026
Copilot stopped work on behalf of
pelikhan due to an error
April 23, 2026 06:07
Contributor
There was a problem hiding this comment.
Pull request overview
Adds consistent errorHelpersLog.Enabled() guards around debug logging in workflow error constructors to match the existing guarded pattern used elsewhere.
Changes:
- Guard
errorHelpersLog.Printf(...)calls inNewValidationError - Guard
errorHelpersLog.Printf(...)calls inNewConfigurationError
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/workflow_errors.go | Adds Enabled() checks before emitting constructor debug logs for validation/config errors. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Closed
github-actions Bot
added a commit
that referenced
this pull request
Apr 23, 2026
…rrors.go PR #27990 fixed the missing Enabled() guard on errorHelpersLog calls. Apply the same pattern consistently to errorAggregationLog and sharedWorkflowLog calls in the same file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errorHelpersLog.Enabled()guards toNewValidationErrorandNewConfigurationErrormake agent-finish)