Conversation
…rrors.go PR #27990 fixed the missing Enabled() guard on errorHelpersLog calls. Apply the same pattern consistently to errorAggregationLog and sharedWorkflowLog calls in the same file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
approved these changes
Apr 23, 2026
pelikhan
deleted the
simplify/logging-guards-workflow-errors-8fa4c177dd6d569f
branch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies consistent Enabled() guards to remaining unguarded debug logger calls in workflow_errors.go, aligning errorAggregationLog and sharedWorkflowLog usage with the existing guarded errorHelpersLog pattern to avoid unnecessary logging-call overhead when debug logging is disabled.
Changes:
- Wrapped 4
errorAggregationLogcalls withif errorAggregationLog.Enabled() { ... }. - Wrapped 1
sharedWorkflowLogcall withif sharedWorkflowLog.Enabled() { ... }. - Kept logging behavior unchanged when the relevant logger namespace is enabled.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/workflow_errors.go |
Adds Enabled() guards around remaining debug logger calls for consistent, low-overhead logging behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #27990 fixed the missing
Enabled()guard onerrorHelpersLogcalls but the same file had the same issue onerrorAggregationLogandsharedWorkflowLogcalls.Files Simplified
pkg/workflow/workflow_errors.go— addedEnabled()guards to the remaining 5 unguarded logger callsImprovements Made
Applied consistent logging guard pattern throughout the file:
errorHelpersLogerrorAggregationLogsharedWorkflowLogUnguarded
log.Printf()calls pay the cost of formatting the string even when debug logging is disabled. TheEnabled()guard prevents unnecessary string formatting, consistent with the project's zero-overhead logging philosophy documented in AGENTS.md.Changes Based On
Recent changes from:
Testing
make build)Review Focus
Please verify all
errorAggregationLogandsharedWorkflowLogcalls now follow the same pattern aserrorHelpersLog.