[security-fix] Security Fix: Prevent clear-text logging of sensitive information (Alert #34)#3272
Closed
github-actions[bot] wants to merge 2 commits intomainfrom
Closed
Conversation
This commit addresses CodeQL security alert #34 by removing detailed error messages from workflow compilation failures that could potentially expose sensitive information from secret configurations. **Alert Details:** - Alert Number: #34 - Severity: High - Rule: go/clear-text-logging - CWE: CWE-312, CWE-315, CWE-359 **Changes Made:** - Modified pkg/cli/mcp_add.go line 147-149 to log generic error message - Removed direct inclusion of error details in console output - Error details are no longer passed through fmt.Sprintf which could leak sensitive data from the compilation process **Security Impact:** - Prevents potential exposure of secret values or sensitive configuration data in compilation error messages - Maintains user experience by still informing them of compilation failure - Users can still run 'gh aw compile --verbose' for detailed debugging **Testing:** - The fix maintains existing functionality - Generic error message provides sufficient information for users - Sensitive data no longer flows from secrets to logging output 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
pelikhan
reviewed
Nov 5, 2025
pkg/cli/mcp_add.go
Outdated
| if err := compiler.CompileWorkflow(workflowPath); err != nil { | ||
| mcpAddLog.Printf("Workflow compilation failed: %v", err) | ||
| fmt.Println(console.FormatWarningMessage(fmt.Sprintf("Workflow compilation failed: %v", err))) | ||
| // Log generic error message to avoid exposing sensitive information |
Contributor
There was a problem hiding this comment.
@copilot this is a compiler error that needs to be shown.
Contributor
* Initial plan * Show compiler errors to users in mcp add command Restored display of compilation error messages in pkg/cli/mcp_add.go. The previous security fix was overly broad - compilation errors from CompileWorkflow() are already formatted for user display and don't contain sensitive information. These errors help users fix syntax and validation issues in their workflow files. The error is now printed to stderr as intended, while debug logs still capture the error details for troubleshooting. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
deleted the
security-fix-alert-34-clear-text-logging-18d0a7021be738bb
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: Clear-text Logging of Sensitive Information
Alert Number: #34
Severity: High
Rule: go/clear-text-logging
Vulnerability Description
CodeQL detected that sensitive data from secret configurations could flow through error messages to logging output. When workflow compilation fails, the error message (which may contain secret references or values) was being logged in clear text to the console and debug logs.
The vulnerability was identified in
pkg/cli/mcp_add.go:148where workflow compilation errors were logged with full error details usingfmt.Sprintf("Workflow compilation failed: %v", err). This creates a data flow path where sensitive information fromsecretKeysand related secret processing could be exposed in logs.Fix Applied
Modified the error handling in
pkg/cli/mcp_add.go(lines 147-150) to:Before:
After:
Security Best Practices
This fix follows OWASP recommendations for handling sensitive information:
${{ secrets.NAME }}, we avoid any potential leakage through error messagesTesting Considerations
gh aw compiledirectly for detailed debugging if neededReferences
🤖 Generated with Claude Code