Restore compiler error display in mcp add command#3273
Merged
pelikhan merged 2 commits intosecurity-fix-alert-34-clear-text-logging-18d0a7021be738bbfrom Nov 5, 2025
Merged
Conversation
Restored display of compilation error messages in pkg/cli/mcp_add.go. The previous security fix was overly broad - compilation errors from CompileWorkflow() are already formatted for user display and don't contain sensitive information. These errors help users fix syntax and validation issues in their workflow files. The error is now printed to stderr as intended, while debug logs still capture the error details for troubleshooting. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compiler error in security fix PR
Restore compiler error display in mcp add command
Nov 5, 2025
pelikhan
merged commit 7c7cb75
into
security-fix-alert-34-clear-text-logging-18d0a7021be738bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security fix in PR #3272 suppressed all compilation errors, but
CompileWorkflow()returns formatted diagnostic messages (syntax errors, validation failures) that users need to fix their workflows.Changes
fmt.Fprintln(os.Stderr, err)mcpAddLog.Printf("Workflow compilation failed: %v", err)Example
When a workflow has invalid YAML syntax, users now see:
Instead of the generic "Workflow compilation failed. Please check your workflow configuration."
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.