Add minItems constraints to array fields requiring values#7597
Merged
Add minItems constraints to array fields requiring values#7597
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add minItems constraints for array fields requiring values
Add minItems constraints to array fields requiring values
Dec 25, 2025
pelikhan
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several array fields in the workflow schema allowed empty arrays that fail at compile time (e.g.,
toolsets: [],names: []for label triggers). The schema now enforcesminItems: 1where semantically required.Changes
Schema constraints added (
pkg/parser/schemas/main_workflow_schema.json):on.issues.namesarray - label filter for labeled/unlabeled eventson.pull_request.namesarray - label filter for labeled/unlabeled eventstools.github.toolsetsarray - at least one toolset required when specifiedException:
network.allowedhas NO minItems constraint - empty arrays are valid for deny-all network access semantics.Test coverage (
pkg/parser/schema_test.go):Example
Error messages clearly indicate the constraint:
minItems: got 0, want 1Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login husky git 64/bin/go js/**/*.json 64/pkg/tool/linuenv ache/node/24.12.-json /opt/hostedtoolcGO111MODULE -V=f�� ck '**/*.cjs' '*GOINSECURE git ache/go/1.25.0/xGOMODCACHE /\1/p Test User ps ache/go/1.25.0/xGOPROXY(http block)/usr/bin/gh gh api user --jq .login runs/20251225-071606-23682/test-3056621916/.github/workflows GOPROXY /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet GOSUMDB GOWORK 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linu--jq -ato�� ithub/workflows -buildtags(http block)/usr/bin/gh gh api user --jq .login ithub/workflows -importcfg /usr/bin/git -s -w -buildmode=exe git -C k/gh-aw/gh-aw/.github/workflows rev-parse /usr/bin/git edcfg git 64/bin/go git(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.