Skip to content

Add minItems constraints to array fields requiring values #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Dec 25, 2025
Merged

Add minItems constraints to array fields requiring values #7597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47b2707
Initial plan
Copilot Dec 25, 2025
cfe977b
Initial plan for adding minItems constraints
Copilot Dec 25, 2025
27a0dc1
Add minItems constraints to array fields requiring values
Copilot Dec 25, 2025
ec255a0
Final validation: minItems constraints implementation complete
Copilot Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions pkg/parser/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,45 @@ func TestValidateMainWorkflowFrontmatterWithSchema(t *testing.T) {
wantErr: true,
errContains: "minItems: got 0, want 1",
},
{
name: "invalid empty toolsets array",
frontmatter: map[string]any{
"on": "push",
"tools": map[string]any{
"github": map[string]any{
"toolsets": []string{},
},
},
},
wantErr: true,
errContains: "minItems",
},
{
name: "invalid empty issue names array",
frontmatter: map[string]any{
"on": map[string]any{
"issues": map[string]any{
"types": []string{"labeled"},
"names": []string{},
},
},
},
wantErr: true,
errContains: "minItems",
},
{
name: "invalid empty pull_request names array",
frontmatter: map[string]any{
"on": map[string]any{
"pull_request": map[string]any{
"types": []string{"labeled"},
"names": []string{},
},
},
},
wantErr: true,
errContains: "minItems",
},
{
name: "valid schedule with multiple cron entries",
frontmatter: map[string]any{
Expand Down
48 changes: 16 additions & 32 deletions pkg/parser/schemas/main_workflow_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,7 @@
},
{
"not": {
"anyOf": [
{ "required": ["branches"] },
{ "required": ["branches-ignore"] }
]
"anyOf": [{ "required": ["branches"] }, { "required": ["branches-ignore"] }]
}
}
],
Expand All @@ -305,10 +302,7 @@
},
{
"not": {
"anyOf": [
{ "required": ["paths"] },
{ "required": ["paths-ignore"] }
]
"anyOf": [{ "required": ["paths"] }, { "required": ["paths-ignore"] }]
}
}
]
Expand Down Expand Up @@ -414,7 +408,8 @@
"items": {
"type": "string",
"description": "Label name"
}
},
"minItems": 1
}
]
}
Expand All @@ -431,10 +426,7 @@
},
{
"not": {
"anyOf": [
{ "required": ["branches"] },
{ "required": ["branches-ignore"] }
]
"anyOf": [{ "required": ["branches"] }, { "required": ["branches-ignore"] }]
}
}
],
Expand All @@ -451,10 +443,7 @@
},
{
"not": {
"anyOf": [
{ "required": ["paths"] },
{ "required": ["paths-ignore"] }
]
"anyOf": [{ "required": ["paths"] }, { "required": ["paths-ignore"] }]
}
}
]
Expand Down Expand Up @@ -486,7 +475,8 @@
"items": {
"type": "string",
"description": "Label name"
}
},
"minItems": 1
}
]
},
Expand Down Expand Up @@ -669,10 +659,7 @@
},
{
"not": {
"anyOf": [
{ "required": ["branches"] },
{ "required": ["branches-ignore"] }
]
"anyOf": [{ "required": ["branches"] }, { "required": ["branches-ignore"] }]
}
}
]
Expand Down Expand Up @@ -996,10 +983,7 @@
},
{
"not": {
"anyOf": [
{ "required": ["branches"] },
{ "required": ["branches-ignore"] }
]
"anyOf": [{ "required": ["branches"] }, { "required": ["branches-ignore"] }]
}
}
],
Expand All @@ -1016,10 +1000,7 @@
},
{
"not": {
"anyOf": [
{ "required": ["paths"] },
{ "required": ["paths-ignore"] }
]
"anyOf": [{ "required": ["paths"] }, { "required": ["paths-ignore"] }]
}
}
]
Expand Down Expand Up @@ -1899,7 +1880,8 @@
"items": {
"type": "string",
"description": "Domain name or ecosystem identifier (supports wildcards like '*.example.com' and ecosystem names like 'python', 'node')"
}
},
"$comment": "Empty array is valid and means deny all network access. Omit the field entirely or use network: defaults to use default network permissions."
},
"firewall": {
"description": "AWF (Agent Workflow Firewall) configuration for network egress control. Only supported for Copilot engine.",
Expand Down Expand Up @@ -2406,7 +2388,9 @@
"stargazers",
"users"
]
}
},
"minItems": 1,
"$comment": "At least one toolset is required when toolsets array is specified. Use null or omit the field to use all toolsets."
}
},
"additionalProperties": false,
Expand Down
Loading