Skip to content

Fix engine.version to accept numeric types per schema #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Dec 31, 2025
Merged

Fix engine.version to accept numeric types per schema #8231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6082853
Initial plan
Copilot Dec 31, 2025
361d009
Fix engine.version to accept numeric types (int, float)
Copilot Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkg/workflow/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,13 @@ func (c *Compiler) ExtractEngineConfig(frontmatter map[string]any) (string, *Eng

// Extract optional 'version' field
if version, hasVersion := engineObj["version"]; hasVersion {
if versionStr, ok := version.(string); ok {
config.Version = versionStr
switch v := version.(type) {
case string:
config.Version = v
case int, int64, uint64:
config.Version = fmt.Sprintf("%d", v)
case float64:
config.Version = fmt.Sprintf("%g", v)
}
}

Expand Down
22 changes: 22 additions & 0 deletions pkg/workflow/engine_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,28 @@ func TestExtractEngineConfig(t *testing.T) {
expectedEngineSetting: "claude",
expectedConfig: &EngineConfig{ID: "claude", Version: "beta"},
},
{
name: "object format - with integer version",
frontmatter: map[string]any{
"engine": map[string]any{
"id": "copilot",
"version": 20,
},
},
expectedEngineSetting: "copilot",
expectedConfig: &EngineConfig{ID: "copilot", Version: "20"},
},
{
name: "object format - with float version",
frontmatter: map[string]any{
"engine": map[string]any{
"id": "claude",
"version": 3.11,
},
},
expectedEngineSetting: "claude",
expectedConfig: &EngineConfig{ID: "claude", Version: "3.11"},
},
{
name: "object format - with model",
frontmatter: map[string]any{
Expand Down