Fix missing awmg integration test coverage and optimize CI matrix#8521
Merged
Fix missing awmg integration test coverage and optimize CI matrix#8521
Conversation
- Add AWMG Gateway Tests matrix entry for ./pkg/awmg package - Remove "Workflow Expression & Safety" group (0 tests matched) - Remove "Workflow Job Management" group (0 tests matched) - Add comments documenting slow CLI tests (~65s and ~43s) - Update skip_pattern in Workflow Misc Part 2 to reflect removed groups - Fix awmg integration test compilation errors: - Add types import to gateway_integration_test.go - Add types import to gateway_inspect_integration_test.go - Update MCPServerConfig struct initialization to use BaseMCPServerConfig - Fix all 8 struct literal compilation errors across 3 test files Matrix changes: 33 → 32 groups (net -1, removed 2 + added 1) Critical fix: awmg integration tests now compile and can run in CI Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing AWMG integration test coverage and optimize CI matrix
Fix missing awmg integration test coverage and optimize CI matrix
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The awmg package integration tests were not executing in CI due to compilation errors and missing matrix configuration. This caused 3 test files with MCP gateway tests to be completely untested in production.
Changes
CI Matrix Optimization (
.github/workflows/ci.yml)./pkg/awmgpackageFixed awmg Test Compilation (
pkg/awmg/*_test.go)parser.MCPServerConfigtypesimport to gateway test filesThe issue was Go's limitation with embedded struct fields in literals:
All 21 awmg integration tests now compile and pass (22.87s locally).
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login ut-3197140303.c .cfg 0.1-go1.25.0.lin/var/log/sysstat --gdwarf-5 --64(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>[ci-coach] Fix missing awmg integration test coverage and optimize CI matrix</issue_title>
<issue_description>## CI Optimization - Critical Coverage Gap + Matrix Cleanup
This PR addresses a critical test coverage gap discovered during automated CI analysis, along with efficiency improvements to the integration test matrix.
🚨 Critical Finding: Missing Test Coverage
Issue: Integration tests for
./pkg/awmgpackage were NOT being executed in CIImpact:
Files affected:
./pkg/awmg/gateway_integration_test.go./pkg/awmg/gateway_streamable_http_test.go./pkg/awmg/gateway_inspect_integration_test.goFix: ✅ Added matrix entry "AWMG Gateway Tests" to execute all awmg integration tests
🧹 Optimization: Matrix Cleanup
Issue: Empty test groups wasting CI slots
Groups removed (0 tests each):
Fix: ✅ Removed 2 empty groups from integration matrix
📊 Matrix Balance Analysis
Current state after optimizations:
Notable slow groups (documented for future optimization):
TestProgressFlagSignature)TestConnectHTTPMCPServer)Added inline comments in CI config to document these slow tests for future performance work.
✅ Changes Made
.github/workflows/ci.yml./pkg/awmgpackage📈 Impact Summary
🔍 Analysis Methodology
This optimization was discovered through:
./pkg/awmgpackage with integration tests but no CI coverageData analyzed:
🎯 Risk Assessment
Risk Level: Very Low
✅ Added coverage is critical - MCP gateway tests were previously untested
✅ Removed groups are safe - confirmed 0 tests matched their patterns
✅ No test logic changes - only matrix grouping modified
✅ Documented slow tests - for future optimization without changing behavior
🧪 Testing Plan
📚 Related Work
🔮 Future Optimization Opportunities
Documented but not addressed in this PR:
These are marked with inline comments in the CI config for future work.
Metrics Baseline (for future comparison):
References:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.