Skip to content

Fix missing awmg integration test coverage and optimize CI matrix #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jan 1, 2026
Merged

Fix missing awmg integration test coverage and optimize CI matrix #8521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
382b8d9
Initial plan
Copilot Jan 1, 2026
942c2fe
Fix awmg integration test coverage and CI matrix optimization
Copilot Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ jobs:
- name: "CLI Logs & Firewall"
packages: "./pkg/cli"
pattern: "TestLogs|TestFirewall|TestNoStopTime|TestLocalWorkflow"
- name: "CLI Progress Flag" # Isolate slow 30s test
- name: "CLI Progress Flag" # Isolate slow test (~65s for TestProgressFlagSignature)
packages: "./pkg/cli"
pattern: "TestProgressFlagSignature"
- name: "CLI HTTP MCP Connect" # Isolate slow HTTP MCP connection tests
- name: "CLI HTTP MCP Connect" # Isolate slow HTTP MCP connection tests (~43s)
packages: "./pkg/cli"
pattern: "TestConnectHTTPMCPServer"
- name: "CLI Compile Workflows" # Isolate slow workflow compilation test
Expand Down Expand Up @@ -153,12 +153,6 @@ jobs:
- name: "Workflow Permissions"
packages: "./pkg/workflow"
pattern: "TestPermissions|TestPackageExtractor|TestCollectPackagesFromWorkflow"
- name: "Workflow Expression & Safety"
packages: "./pkg/workflow"
pattern: "TestExpression|TestValidateExpressionSafety|TestCheckNetworkSupport|TestValidateStrictMCPNetwork"
- name: "Workflow Job Management"
packages: "./pkg/workflow"
pattern: "TestJobManager|TestWorkflowStep|TestScriptRegistry"
- name: "Workflow Misc Part 1" # Split large catch-all into two balanced groups
packages: "./pkg/workflow"
pattern: "TestAgent|TestCopilot|TestCustom|TestEngine|TestModel|TestNetwork|TestOpenAI|TestProvider"
Expand All @@ -171,7 +165,10 @@ jobs:
- name: "Workflow Misc Part 2" # Remaining workflow tests
packages: "./pkg/workflow"
pattern: ""
skip_pattern: "TestCompile|TestWorkflow|TestGenerate|TestParse|TestMCP|TestTool|TestSkill|TestPlaywright|TestFirewall|TestValidat|TestLock|TestError|TestWarning|SafeOutputs|CreatePullRequest|OutputLabel|HasSafeOutputs|GitHub|Git|PushToPullRequest|BuildFromAllowed|Render|Bundle|Script|WritePromptText|^TestCache|TestCacheDependencies|TestCacheKey|TestValidateCache|^TestActionPinSHAsMatchVersionTags|^TestAction[^P]|Container|Dependabot|Security|PII|TestPermissions|TestPackageExtractor|TestCollectPackagesFromWorkflow|TestExpression|TestValidateExpressionSafety|TestCheckNetworkSupport|TestValidateStrictMCPNetwork|TestJobManager|TestWorkflowStep|TestScriptRegistry|TestAgent|TestCopilot|TestCustom|TestEngine|TestModel|TestNetwork|TestOpenAI|TestProvider|String|Sanitize|Normalize|Trim|Clean|Format|Runtime|Setup|Install|Download|Version|Binary"
skip_pattern: "TestCompile|TestWorkflow|TestGenerate|TestParse|TestMCP|TestTool|TestSkill|TestPlaywright|TestFirewall|TestValidat|TestLock|TestError|TestWarning|SafeOutputs|CreatePullRequest|OutputLabel|HasSafeOutputs|GitHub|Git|PushToPullRequest|BuildFromAllowed|Render|Bundle|Script|WritePromptText|^TestCache|TestCacheDependencies|TestCacheKey|TestValidateCache|^TestActionPinSHAsMatchVersionTags|^TestAction[^P]|Container|Dependabot|Security|PII|TestPermissions|TestPackageExtractor|TestCollectPackagesFromWorkflow|TestAgent|TestCopilot|TestCustom|TestEngine|TestModel|TestNetwork|TestOpenAI|TestProvider|String|Sanitize|Normalize|Trim|Clean|Format|Runtime|Setup|Install|Download|Version|Binary"
- name: "AWMG Gateway Tests" # MCP gateway integration tests
packages: "./pkg/awmg"
pattern: ""
concurrency:
group: ci-${{ github.ref }}-integration-${{ matrix.test-group.name }}
cancel-in-progress: true
Expand Down
7 changes: 5 additions & 2 deletions pkg/awmg/gateway_inspect_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"time"

"github.com/githubnext/gh-aw/pkg/parser"
"github.com/githubnext/gh-aw/pkg/types"
)

// TestMCPGateway_InspectWithPlaywright tests the MCP gateway by:
Expand Down Expand Up @@ -70,8 +71,10 @@ This workflow tests the MCP gateway configuration and tool list.
config := MCPGatewayServiceConfig{
MCPServers: map[string]parser.MCPServerConfig{
"gh-aw": {
Command: binaryPath,
Args: []string{"mcp-server"},
BaseMCPServerConfig: types.BaseMCPServerConfig{
Command: binaryPath,
Args: []string{"mcp-server"},
},
},
},
Gateway: GatewaySettings{
Expand Down
7 changes: 5 additions & 2 deletions pkg/awmg/gateway_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"time"

"github.com/githubnext/gh-aw/pkg/parser"
"github.com/githubnext/gh-aw/pkg/types"
)

func TestMCPGateway_BasicStartup(t *testing.T) {
Expand All @@ -28,8 +29,10 @@ func TestMCPGateway_BasicStartup(t *testing.T) {
config := MCPGatewayServiceConfig{
MCPServers: map[string]parser.MCPServerConfig{
"gh-aw": {
Command: binaryPath,
Args: []string{"mcp-server"},
BaseMCPServerConfig: types.BaseMCPServerConfig{
Command: binaryPath,
Args: []string{"mcp-server"},
},
},
},
Gateway: GatewaySettings{
Expand Down
12 changes: 8 additions & 4 deletions pkg/awmg/gateway_streamable_http_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ func TestStreamableHTTPTransport_GatewayConnection(t *testing.T) {
config := MCPGatewayServiceConfig{
MCPServers: map[string]parser.MCPServerConfig{
"gh-aw": {
Command: binaryPath,
Args: []string{"mcp-server"},
BaseMCPServerConfig: types.BaseMCPServerConfig{
Command: binaryPath,
Args: []string{"mcp-server"},
},
},
},
Gateway: GatewaySettings{
Expand Down Expand Up @@ -448,8 +450,10 @@ func TestStreamableHTTPTransport_GatewayWithSDKClient(t *testing.T) {
config := MCPGatewayServiceConfig{
MCPServers: map[string]parser.MCPServerConfig{
"gh-aw": {
Command: binaryPath,
Args: []string{"mcp-server"},
BaseMCPServerConfig: types.BaseMCPServerConfig{
Command: binaryPath,
Args: []string{"mcp-server"},
},
},
},
Gateway: GatewaySettings{
Expand Down
Loading