Consolidate agent job artifact uploads into single step by Copilot · Pull Request #8835 · github/gh-aw

Copilot · 2026-01-04T04:10:48Z

Refactor agent job artifact uploads into single step

Implementation Complete ✅

Summary of Changes

New Unified Upload Function:

Added generateUnifiedArtifactUpload() in compiler_yaml_artifacts.go
Single upload step named "Upload agent artifacts"
Uses multi-line YAML path syntax for included artifacts
Always runs with if: always() and continue-on-error: true
Ignores missing files with if-no-files-found: ignore

Artifacts Consolidated into Unified Upload:

/tmp/gh-aw/aw-prompts/prompt.txt (prompt)
/tmp/gh-aw/aw_info.json (workflow info)
/tmp/gh-aw/mcp-logs/ (MCP server logs)
/tmp/gh-aw/safe-inputs/logs/ (SafeInputs logs)
/tmp/gh-aw/sandbox/firewall/logs/ (firewall logs)
/tmp/gh-aw/agent-stdio.log (agent stdio)
/tmp/gh-aw/safeoutputs/assets/ (safe-outputs assets)
/tmp/gh-aw/aw.patch (git patches)

Preserved Separate Uploads:

Safe-outputs raw upload (safe-output artifact) - Required for dependent jobs
Safe-outputs sanitized upload (agent-output artifact) - Required for dependent jobs
Repo-memory artifacts - Per feedback, kept as separate upload steps
Cache-memory artifacts - Per feedback, kept as separate upload steps

Artifact Flattening for Downloads:

Added flattenUnifiedArtifact() in pkg/cli/logs_download.go
Handles nested agent-artifacts/tmp/gh-aw/ structure created by GitHub Actions
Moves files from nested path to root output directory
Preserves directory structure (e.g., aw-prompts/, mcp-logs/)
Integrated into downloadRunArtifacts() workflow
Added comprehensive tests in logs_flatten_test.go

Test Updates:

All 6 failing tests updated to expect unified upload where appropriate
Cache-memory tests updated to expect separate upload steps
Added TestFlattenUnifiedArtifact to verify download flattening
All tests passing (flatten, logs, workflow compilation)

Benefits:

✅ Reduced workflow complexity (10 uploads → 3: unified + cache-memory + repo-memory)
✅ Improved reliability (always runs, ignores missing files)
✅ Easier debugging (most artifacts in one place)
✅ Consistent behavior across all workflows
✅ Seamless download experience with artifact flattening
✅ All tests passing

Original prompt

Refactor all actions/upload-artifact steps in the agent job into a single step that uploads all the files in a single artifacts. This step should always run, even if cancelled, failed, etc... and ignore missing files.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Changeset

Type: patch
Description: Consolidate multiple actions/upload-artifact steps into a single "Upload agent artifacts" step with consistent error handling; preserve separate uploads for safe-outputs raw/sanitized, repo-memory, and cache-memory. Updated tests to cover the new unified upload behavior.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

- Create generateUnifiedArtifactUpload function to upload all artifacts in one step - Collect all artifact paths throughout main job generation - Replace individual upload calls with path collection - Unified upload runs with if: always(), continue-on-error: true, and if-no-files-found: ignore - Consolidated: prompt, aw_info, MCP logs, firewall logs, agent stdio, cache-memory, repo-memory, safe-outputs assets, git patches - Note: Safe-outputs raw/sanitized uploads remain separate as they're used by dependent jobs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-01-04T04:44:58Z

@copilot keep repo-memory and cache-memory artifacts separate

- Updated TestPromptUploadArtifact to check for unified upload - Updated TestCacheMemoryWithThreatDetection for multiple cache scenarios - Updated TestGitPatchGeneration to verify patch in unified upload - Updated TestMCPLogsUpload to check for MCP logs in unified upload - Updated TestStepOrderingValidation to check agent-artifacts upload - Updated TestAwInfoTmpPath to verify aw_info in unified upload - All unit tests now passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

- Restored generateRepoMemoryArtifactUpload() call - Restored generateCacheMemoryArtifactUpload() call - Removed repo-memory and cache-memory from unified upload - Updated tests to expect separate upload steps - All tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-01-04T05:01:08Z

@copilot keep repo-memory and cache-memory artifacts separate

Done in commit 5e28108. Repo-memory and cache-memory now have separate upload steps:

- name: Upload cache-memory data as artifact
  uses: actions/upload-artifact@...
  if: always()
  with:
    name: cache-memory
    path: /tmp/gh-aw/cache-memory

# ... other steps ...

- name: Upload agent artifacts
  if: always()
  continue-on-error: true
  uses: actions/upload-artifact@...
  with:
    name: agent-artifacts
    path: |
      /tmp/gh-aw/aw-prompts/prompt.txt
      /tmp/gh-aw/aw_info.json
      /tmp/gh-aw/mcp-logs/
      /tmp/gh-aw/sandbox/firewall/logs/
      /tmp/gh-aw/agent-stdio.log

The unified upload now includes: prompt, aw_info, MCP logs, SafeInputs logs, firewall logs, agent stdio, safe-outputs assets, and git patches.

github-actions · 2026-01-04T05:08:00Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-01-04T05:08:01Z

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

github-actions · 2026-01-04T05:08:01Z

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

github-actions · 2026-01-04T05:08:01Z

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

github-actions · 2026-01-04T05:08:02Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-01-04T05:08:02Z

📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-01-04T05:08:04Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-01-04T05:08:05Z

🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰

github-actions · 2026-01-04T05:09:51Z

Smoke Test Results: Copilot Safe Inputs

✅ File Writing: Created /tmp/gh-aw/agent/smoke-test-copilot-20688004136.txt successfully
✅ Bash Tool: Verified file content with cat command
❌ Safe Input gh Tool: safeinputs-gh tool not available in environment

Overall Status: FAIL (1/3 tests passed)

AI generated by Smoke Copilot Safe Inputs

github-actions · 2026-01-04T05:09:55Z

Smoke test results:

PRs: [security-fix] Fix hardcoded credentials false positive in copilot execution (Alert #440) #8840 "[security-fix] Fix hardcoded credentials false positive in copilot execution (Alert [Custom Engine Test] Test Pull Request - Custom Engine Safe Output #440)", Add test coverage for importing neutral tools (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout) #8838 "Add test coverage for importing neutral tools (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout)"
OpenAI curl: ✅ blocked (host resolve failed)
GitHub MCP (merged PR titles): ✅
File write/read (/tmp/gh-aw/agent/smoke-test-codex-firewall-20688004127.txt): ✅
Blocked domain curl (example.com): ✅ blocked (host resolve failed)
Network: SANDBOXED
Overall: PASS

AI generated by Smoke Codex Firewall

github-actions · 2026-01-04T05:10:11Z

Smoke Test Results

✅ All tests passed

GitHub API: Retrieved 2 merged PRs ([security-fix] Fix hardcoded credentials false positive in copilot execution (Alert #440) #8840, Add test coverage for importing neutral tools (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout) #8838)
File system: Created test file successfully
Playwright: Navigated to GitHub and verified page title
safeinputs-gh: Listed 3 issues (#8844, Metrics Data Infrastructure Investigation - Accessibility Issue #8843, Workflow Complexity Reduction Initiative #8842)

AI generated by Smoke Copilot No Firewall

github-actions · 2026-01-04T05:10:11Z

Copilot Engine Smoke Test Results

Recent PRs: #8838 (Import neutral tools), #8840 (Security fix)

✅ GitHub MCP - Retrieved 2 merged PRs
✅ File Writing - Created /tmp/gh-aw/agent/smoke-test-copilot-20688004117.txt
✅ Bash Tool - Verified file creation successful
✅ Default Toolset - Confirmed get_me NOT available (403 error as expected)
✅ Cache Memory - Created and verified /tmp/gh-aw/cache-memory/smoke-test-20688004117.txt
✅ Tools Available - bash, view, create, edit, glob, grep, github-* (default toolsets)

Status: PASS

cc: @pelikhan (PR author/assignee)

AI generated by Smoke Copilot

github-actions · 2026-01-04T05:10:28Z

Smoke Test Results

❌ Playwright MCP: Tool not available (command not found)
✅ Cache Memory: File created and verified successfully
❌ safeinputs-gh Tool: Command not found

Overall Status: FAIL

Playwright MCP and safeinputs-gh tools are not configured in this workflow environment.

AI generated by Smoke Copilot Playwright

github-actions · 2026-01-04T05:10:37Z

Smoke Test Results - Claude Engine

Last 2 Merged PRs:

Add test coverage for importing neutral tools (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout) #8838: Add test coverage for importing neutral tools
[security-fix] Fix hardcoded credentials false positive in copilot execution (Alert #440) #8840: Fix hardcoded credentials false positive in copilot execution

Test Results:
✅ GitHub MCP - Fetched recent PRs
✅ File Writing - Created /tmp/gh-aw/agent/smoke-test-claude-20688004150.txt
✅ Bash Tool - Verified file creation
✅ Playwright MCP - Navigated to GitHub, title verified
✅ Cache Memory - Created /tmp/gh-aw/cache-memory/smoke-test-20688004150.txt
❌ Safe Input gh Tool - Tool not available in this workflow

Overall Status: PASS (5/6 tests passed)

AI generated by Smoke Claude

github-actions · 2026-01-04T05:10:51Z

PRs: [security-fix] Fix hardcoded credentials false positive in copilot execution (Alert #440); Add test coverage for importing neutral tools (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout)
GitHub MCP: ✅
File write/read: ✅
Playwright title check: ✅
Cache memory write/read: ✅
Safeinputs-gh issues list: ❌ (tool missing)
Overall: FAIL

AI generated by Smoke Codex

pelikhan · 2026-01-04T05:11:49Z

@copilot make sure artifact flattening works in the download logs command

- Added flattenUnifiedArtifact() to handle nested tmp/gh-aw/ structure - Unified artifact contains files with full paths (/tmp/gh-aw/*) - When downloaded, creates agent-artifacts/tmp/gh-aw/ nesting - Flattening moves files from nested path to root output directory - Preserves directory structure (aw-prompts/, mcp-logs/, etc.) - Added comprehensive tests for unified artifact flattening - All existing flatten tests continue to pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-01-04T05:22:14Z

@copilot make sure artifact flattening works in the download logs command

Done in commit 1a63a46. Added flattenUnifiedArtifact() function that handles the nested structure created when downloading the unified artifact.

The unified artifact contains files with full paths like /tmp/gh-aw/*, which when downloaded by gh run download creates:

agent-artifacts/
  tmp/
    gh-aw/
      aw_info.json
      aw-prompts/prompt.txt
      mcp-logs/...

The flattening function moves these files to the root output directory, preserving subdirectory structures, so the final result is:

aw_info.json
aw-prompts/prompt.txt
mcp-logs/...

Added comprehensive tests to verify the flattening works correctly.

Initial plan

73d45a2

Copilot AI assigned Copilot and pelikhan Jan 4, 2026

Copilot started work on behalf of pelikhan January 4, 2026 04:11 View session

Copilot AI changed the title ~~[WIP] Refactor agent job to upload artifacts in a single step~~ Consolidate agent job artifact uploads into single step Jan 4, 2026

Copilot finished work on behalf of pelikhan January 4, 2026 04:51

Copilot AI requested a review from pelikhan January 4, 2026 04:51

Copilot started work on behalf of pelikhan January 4, 2026 04:51 View session

Copilot finished work on behalf of pelikhan January 4, 2026 05:02

pelikhan added the smoke label Jan 4, 2026

github-actions bot added the smoke-codex-firewall label Jan 4, 2026

github-actions bot added smoke-copilot-no-firewall smoke-copilot labels Jan 4, 2026

pelikhan marked this pull request as ready for review January 4, 2026 05:10

github-actions bot added the smoke-claude label Jan 4, 2026

Copilot started work on behalf of pelikhan January 4, 2026 05:12 View session

Copilot finished work on behalf of pelikhan January 4, 2026 05:23

pelikhan merged commit 2068bb3 into main Jan 4, 2026
4 checks passed

pelikhan deleted the copilot/refactor-upload-artifact-steps branch January 4, 2026 05:24

github-actions bot mentioned this pull request Jan 4, 2026

Update tests and PR helpers for unified agent artifact structure #8846

Merged

Conversation

Copilot AI commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Refactor agent job artifact uploads into single step

Implementation Complete ✅

Summary of Changes

Changeset

Uh oh!

pelikhan commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026 • edited by agentic-workflows-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026

Smoke Test Results: Copilot Safe Inputs

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Smoke Test Results

Uh oh!

github-actions bot commented Jan 4, 2026

Copilot Engine Smoke Test Results

Uh oh!

github-actions bot commented Jan 4, 2026

Smoke Test Results

Uh oh!

github-actions bot commented Jan 4, 2026

Smoke Test Results - Claude Engine

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

pelikhan commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 4, 2026 •

edited

Loading

github-actions bot commented Jan 4, 2026 •

edited

Loading

github-actions bot commented Jan 4, 2026 •

edited

Loading

github-actions bot commented Jan 4, 2026 •

edited by agentic-workflows-dev bot

Loading

github-actions bot commented Jan 4, 2026 •

edited

Loading

github-actions bot commented Jan 4, 2026 •

edited

Loading

github-actions bot commented Jan 4, 2026 •

edited

Loading

github-actions bot commented Jan 4, 2026 •

edited

Loading

github-actions bot commented Jan 4, 2026 •

edited

Loading