Skip to content

Add test coverage for importing neutral tools (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout)#8838

Merged
pelikhan merged 2 commits intomainfrom
copilot/add-import-support-tools
Jan 4, 2026
Merged

Add test coverage for importing neutral tools (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout)#8838
pelikhan merged 2 commits intomainfrom
copilot/add-import-support-tools

Conversation

Copy link
Contributor

Copilot AI commented Jan 4, 2026

The problem statement requested adding support to import neutral tools. Investigation revealed the import mechanism already extracts all tools from frontmatter correctly - no code changes needed. Added test coverage to verify and document this capability.

Changes

  • Added 7 test cases to pkg/workflow/importable_tools_test.go:
    • Individual tests for edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout
    • Combined test for importing multiple neutral tools together

Example Usage

# shared-config.md
---
tools:
  edit:
  web-fetch:
  timeout: 90
  startup-timeout: 60
---

# main-workflow.md
---
on: issues
engine: copilot
imports:
  - shared-config.md
---

All neutral tools from shared-config.md are correctly merged into the main workflow's tool configuration. The existing extractToolsFromContent() and MergeTools() functions in pkg/parser/ handle this automatically.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login -json GO111MODULE 0.1-go1.25.0.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/tool/linux_amd64/link (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Add support to import all tools including edit, safety-prompt, startup-timeout, timeout, web-fetch, web-search


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

… web-search, safety-prompt, timeout, startup-timeout)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add support to import all tools including edit, safety-prompt, startup-timeout, timeout, web-fetch, web-search Add test coverage for importing neutral tools (edit, web-fetch, web-search, safety-prompt, timeout, startup-timeout) Jan 4, 2026
Copilot AI requested a review from pelikhan January 4, 2026 04:46
@pelikhan
Copy link
Contributor

pelikhan commented Jan 4, 2026

@copilot lint go

Copy link
Contributor Author

Copilot AI commented Jan 4, 2026

@copilot lint go

Go linting completed successfully with no issues found. All validations passed.

@pelikhan pelikhan marked this pull request as ready for review January 4, 2026 04:53
@pelikhan pelikhan merged commit 6355bc9 into main Jan 4, 2026
4 of 5 checks passed
@pelikhan pelikhan deleted the copilot/add-import-support-tools branch January 4, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants