Skip to content

Rename supportsToolsWhitelist to supportsToolsAllowlist#903

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-cee71117-d746-4025-b3d4-ed7225f10fca
Sep 18, 2025
Merged

Rename supportsToolsWhitelist to supportsToolsAllowlist#903
pelikhan merged 2 commits intomainfrom
copilot/fix-cee71117-d746-4025-b3d4-ed7225f10fca

Conversation

Copy link
Contributor

Copilot AI commented Sep 18, 2025

This PR renames supportsToolsWhitelist to supportsToolsAllowlist throughout the codebase to adopt more inclusive terminology while maintaining the same functionality.

Changes Made

Core Engine Interface:

  • Renamed the BaseEngine struct field from supportsToolsWhitelist to supportsToolsAllowlist
  • Updated the CodingAgentEngine interface method from SupportsToolsWhitelist() to SupportsToolsAllowlist()
  • Updated method documentation to reflect the new terminology

Engine Implementations:

  • Updated all concrete engine constructors (Claude, Codex, Custom) to use the new field name
  • Maintained the same boolean values and behavior for each engine

Method Invocations:

  • Updated all calls to the method across the compiler and CLI code
  • Changed YAML output field from supports_tools_whitelist to supports_tools_allowlist in generated workflows

Tests and Comments:

  • Updated all test files to use the new method name
  • Changed error messages and comments from "whitelist" to "allowlist" terminology

Validation

All existing functionality is preserved:

  • All Go and JavaScript tests pass
  • CLI commands work correctly (verified gh aw list engines shows proper MCP support)
  • Workflow compilation generates the correct YAML with the new field name
  • make agent-finish validation passes (build, test, recompile, fmt, lint)

The change is purely terminological - no logic or behavior has been modified. The generated workflows now use supports_tools_allowlist instead of supports_tools_whitelist in their metadata, which is a non-breaking change for workflow execution.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.contoso.com
    • Triggering command: /tmp/go-build2413458213/b279/cli.test -test.testlogfile=/tmp/go-build2413458213/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
    • Triggering command: /tmp/go-build886410155/b279/cli.test -test.testlogfile=/tmp/go-build886410155/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
    • Triggering command: /tmp/go-build3679227031/b279/cli.test -test.testlogfile=/tmp/go-build3679227031/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

…debase

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename supportsToolsWhitelist to supportsToolsAllowlist Rename supportsToolsWhitelist to supportsToolsAllowlist Sep 18, 2025
Copilot AI requested a review from pelikhan September 18, 2025 01:05
@pelikhan pelikhan marked this pull request as ready for review September 18, 2025 01:07
@pelikhan pelikhan merged commit 1a10273 into main Sep 18, 2025
11 of 17 checks passed
@pelikhan pelikhan deleted the copilot/fix-cee71117-d746-4025-b3d4-ed7225f10fca branch September 18, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants