Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-doctor.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/dev.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ func listAgenticEngines(verbose bool) error {

// MCP support
mcpSupport := "No"
if engine.SupportsToolsWhitelist() {
if engine.SupportsToolsAllowlist() {
mcpSupport = "Yes"
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-ai-inference-github-models.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-add-issue-comment.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-add-issue-labels.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-cache-memory.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-command.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-create-issue.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-create-pull-request.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-max-patch-size.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-mcp.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-missing-tool.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-patch-size-exceeded.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-push-to-pr-branch.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-update-issue.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-codex-add-issue-comment.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-codex-add-issue-labels.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-codex-command.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-codex-custom-env.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions pkg/workflow/agentic_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ type CodingAgentEngine interface {
// IsExperimental returns true if this engine is experimental
IsExperimental() bool

// SupportsToolsWhitelist returns true if this engine supports MCP tool allow-listing
SupportsToolsWhitelist() bool
// SupportsToolsAllowlist returns true if this engine supports MCP tool allow-listing
SupportsToolsAllowlist() bool

// SupportsHTTPTransport returns true if this engine supports HTTP transport for MCP servers
SupportsHTTPTransport() bool
Expand Down Expand Up @@ -78,7 +78,7 @@ type BaseEngine struct {
displayName string
description string
experimental bool
supportsToolsWhitelist bool
supportsToolsAllowlist bool
supportsHTTPTransport bool
supportsMaxTurns bool
}
Expand All @@ -99,8 +99,8 @@ func (e *BaseEngine) IsExperimental() bool {
return e.experimental
}

func (e *BaseEngine) SupportsToolsWhitelist() bool {
return e.supportsToolsWhitelist
func (e *BaseEngine) SupportsToolsAllowlist() bool {
return e.supportsToolsAllowlist
}

func (e *BaseEngine) SupportsHTTPTransport() bool {
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/agentic_engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func TestEngineRegistryCustomEngine(t *testing.T) {
displayName: "Test Custom Engine",
description: "A test custom engine",
experimental: true,
supportsToolsWhitelist: false,
supportsToolsAllowlist: false,
},
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/claude_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func NewClaudeEngine() *ClaudeEngine {
displayName: "Claude Code",
description: "Uses Claude Code with full MCP tool support and allow-listing",
experimental: false,
supportsToolsWhitelist: true,
supportsToolsAllowlist: true,
supportsHTTPTransport: true, // Claude supports both stdio and HTTP transport
supportsMaxTurns: true, // Claude supports max-turns feature
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/claude_engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func TestClaudeEngine(t *testing.T) {
t.Error("Claude engine should not be experimental")
}

if !engine.SupportsToolsWhitelist() {
if !engine.SupportsToolsAllowlist() {
t.Error("Claude engine should support MCP tools")
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/codex_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func NewCodexEngine() *CodexEngine {
displayName: "Codex",
description: "Uses OpenAI Codex CLI with MCP server support",
experimental: true,
supportsToolsWhitelist: true,
supportsToolsAllowlist: true,
supportsHTTPTransport: false, // Codex only supports stdio transport
supportsMaxTurns: false, // Codex does not support max-turns feature
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/codex_engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func TestCodexEngine(t *testing.T) {
t.Error("Codex engine should be experimental")
}

if !engine.SupportsToolsWhitelist() {
if !engine.SupportsToolsAllowlist() {
t.Error("Codex engine should support MCP tools")
}

Expand Down
6 changes: 3 additions & 3 deletions pkg/workflow/compiler.go
Original file line number Diff line number Diff line change
Expand Up @@ -602,8 +602,8 @@ func (c *Compiler) parseWorkflowFile(markdownPath string) (*WorkflowData, error)
return nil, fmt.Errorf("HTTP transport not supported: %w", err)
}

if !agenticEngine.SupportsToolsWhitelist() {
// For engines that don't support tool whitelists (like codex), ignore tools section and provide warnings
if !agenticEngine.SupportsToolsAllowlist() {
// For engines that don't support tool allowlists (like codex), ignore tools section and provide warnings
fmt.Println(console.FormatWarningMessage(fmt.Sprintf("Using experimental %s support (engine: %s)", agenticEngine.GetDisplayName(), engineSetting)))
if _, hasTools := result.Frontmatter["tools"]; hasTools {
fmt.Println(console.FormatWarningMessage(fmt.Sprintf("'tools' section ignored when using engine: %s (%s doesn't support MCP tool allow-listing)", engineSetting, agenticEngine.GetDisplayName())))
Expand Down Expand Up @@ -4585,7 +4585,7 @@ func (c *Compiler) generateCreateAwInfo(yaml *strings.Builder, data *WorkflowDat
// Workflow information
fmt.Fprintf(yaml, " workflow_name: \"%s\",\n", data.Name)
fmt.Fprintf(yaml, " experimental: %t,\n", engine.IsExperimental())
fmt.Fprintf(yaml, " supports_tools_whitelist: %t,\n", engine.SupportsToolsWhitelist())
fmt.Fprintf(yaml, " supports_tools_allowlist: %t,\n", engine.SupportsToolsAllowlist())
fmt.Fprintf(yaml, " supports_http_transport: %t,\n", engine.SupportsHTTPTransport())

// Run metadata
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/custom_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func NewCustomEngine() *CustomEngine {
displayName: "Custom Steps",
description: "Executes user-defined GitHub Actions steps",
experimental: false,
supportsToolsWhitelist: false,
supportsToolsAllowlist: false,
supportsHTTPTransport: false,
supportsMaxTurns: true, // Custom engine supports max-turns for consistency
},
Expand Down
4 changes: 2 additions & 2 deletions pkg/workflow/custom_engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ func TestCustomEngine(t *testing.T) {
t.Error("Expected custom engine to not be experimental")
}

if engine.SupportsToolsWhitelist() {
t.Error("Expected custom engine to not support tools whitelist")
if engine.SupportsToolsAllowlist() {
t.Error("Expected custom engine to not support tools allowlist")
}

if engine.SupportsHTTPTransport() {
Expand Down
Loading