Set time unit on metrics.Timer#610
Merged
peterbourgon merged 2 commits intogo-kit:masterfrom Sep 17, 2017
Merged
Conversation
peterbourgon
requested changes
Sep 15, 2017
Member
peterbourgon
left a comment
peterbourgon
left a comment
There was a problem hiding this comment.
Looks good! Couple of small things before I can merge. The CI failures look unrelated, I'll try to fix those.
metrics/timer.go
Outdated
| t.h.Observe(d) | ||
| } | ||
|
|
||
| // Unit sets the timer time unit |
Member
There was a problem hiding this comment.
Please make this a proper sentence with punctuation, and provide more detail, e.g.
Unit sets the unit of the float64 emitted by the timer. By default, the timer emits seconds.
metrics/timer_test.go
Outdated
| } | ||
|
|
||
| func TestTimerUnit(t *testing.T) { | ||
|
|
Member
There was a problem hiding this comment.
Remove extraneous newline.
Contributor
Author
|
Thanks for your feedback @peterbourgon! I implemented the suggested changes, please have a further review. |
peterbourgon
approved these changes
Sep 15, 2017
Member
|
Thanks! Test failures are unrelated. |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
Set time unit on metrics.Timer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #608.