fix pact test due to breaking api change#720
Merged
peterbourgon merged 1 commit intogo-kit:masterfrom Jun 18, 2018
Merged
Conversation
| } | ||
|
|
||
| pact := dsl.Pact{ | ||
| Port: 6666, |
Member
There was a problem hiding this comment.
How is this specified, now?
Member
Author
There was a problem hiding this comment.
not sure, examples didn't show anything similar.. I wanted to test it on CI as it seemed too much hassle to do locally... documentation is lacking w.r.t. the changes or it's buried somewhere deep :(
Member
Author
There was a problem hiding this comment.
@peterbourgon I see none of our CI environments actually runs it... do you have a local setup to test against?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.