Remove redundant statements in profilesvc example#721
Merged
peterbourgon merged 1 commit intogo-kit:masterfrom Jun 19, 2018
Merged
Remove redundant statements in profilesvc example#721peterbourgon merged 1 commit intogo-kit:masterfrom
peterbourgon merged 1 commit intogo-kit:masterfrom
Conversation
Contributor
Author
|
CI failures are not related to changes made here, see #720. |
Member
|
Can you rebase on master? |
sudo-suhas
force-pushed
the
example-correction
branch
from
2f87397 to
9b76d1f
Compare
Contributor
Author
|
Done. |
In the profilesvc example, both the request method and URL path are set in each specific encoder. This is not required for the request method as that is specified correctly in the call to `httptransport.NewClient`.
sudo-suhas
force-pushed
the
example-correction
branch
from
9b76d1f to
587f274
Compare
Contributor
Author
|
Amended the commit message as it was not getting formatted correctly:
|
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
In the profilesvc example, both the request method and URL path are set in each specific encoder. This is not required for the request method as that is specified correctly in the call to `httptransport.NewClient`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the profilesvc example, both the request method and URL path are set in each specific encoder. This is not required for the request method as that is specified correctly in the call to
httptransport.NewClient. This PR removes the redundant statements.