Skip to content

Remove redundant statements in profilesvc example #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbourgon merged 1 commit into from
Jun 19, 2018
Merged

Remove redundant statements in profilesvc example #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/profilesvc/endpoints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ func MakeClientEndpoints(instance string) (Endpoints, error) {
options := []httptransport.ClientOption{}

// Note that the request encoders need to modify the request URL, changing
// the path and method. That's fine: we simply need to provide specific
// encoders for each endpoint.
// the path. That's fine: we simply need to provide specific encoders for
// each endpoint.

return Endpoints{
PostProfileEndpoint: httptransport.NewClient("POST", tgt, encodePostProfileRequest, decodePostProfileResponse, options...).Endpoint(),
Expand Down
18 changes: 9 additions & 9 deletions examples/profilesvc/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,47 +217,47 @@ func decodeDeleteAddressRequest(_ context.Context, r *http.Request) (request int

func encodePostProfileRequest(ctx context.Context, req *http.Request, request interface{}) error {
// r.Methods("POST").Path("/profiles/")
req.Method, req.URL.Path = "POST", "/profiles/"
req.URL.Path = "/profiles/"
return encodeRequest(ctx, req, request)
}

func encodeGetProfileRequest(ctx context.Context, req *http.Request, request interface{}) error {
// r.Methods("GET").Path("/profiles/{id}")
r := request.(getProfileRequest)
profileID := url.QueryEscape(r.ID)
req.Method, req.URL.Path = "GET", "/profiles/"+profileID
req.URL.Path = "/profiles/" + profileID
return encodeRequest(ctx, req, request)
}

func encodePutProfileRequest(ctx context.Context, req *http.Request, request interface{}) error {
// r.Methods("PUT").Path("/profiles/{id}")
r := request.(putProfileRequest)
profileID := url.QueryEscape(r.ID)
req.Method, req.URL.Path = "PUT", "/profiles/"+profileID
req.URL.Path = "/profiles/" + profileID
return encodeRequest(ctx, req, request)
}

func encodePatchProfileRequest(ctx context.Context, req *http.Request, request interface{}) error {
// r.Methods("PATCH").Path("/profiles/{id}")
r := request.(patchProfileRequest)
profileID := url.QueryEscape(r.ID)
req.Method, req.URL.Path = "PATCH", "/profiles/"+profileID
req.URL.Path = "/profiles/" + profileID
return encodeRequest(ctx, req, request)
}

func encodeDeleteProfileRequest(ctx context.Context, req *http.Request, request interface{}) error {
// r.Methods("DELETE").Path("/profiles/{id}")
r := request.(deleteProfileRequest)
profileID := url.QueryEscape(r.ID)
req.Method, req.URL.Path = "DELETE", "/profiles/"+profileID
req.URL.Path = "/profiles/" + profileID
return encodeRequest(ctx, req, request)
}

func encodeGetAddressesRequest(ctx context.Context, req *http.Request, request interface{}) error {
// r.Methods("GET").Path("/profiles/{id}/addresses/")
r := request.(getAddressesRequest)
profileID := url.QueryEscape(r.ProfileID)
req.Method, req.URL.Path = "GET", "/profiles/"+profileID+"/addresses/"
req.URL.Path = "/profiles/" + profileID + "/addresses/"
return encodeRequest(ctx, req, request)
}

Expand All @@ -266,15 +266,15 @@ func encodeGetAddressRequest(ctx context.Context, req *http.Request, request int
r := request.(getAddressRequest)
profileID := url.QueryEscape(r.ProfileID)
addressID := url.QueryEscape(r.AddressID)
req.Method, req.URL.Path = "GET", "/profiles/"+profileID+"/addresses/"+addressID
req.URL.Path = "/profiles/" + profileID + "/addresses/" + addressID
return encodeRequest(ctx, req, request)
}

func encodePostAddressRequest(ctx context.Context, req *http.Request, request interface{}) error {
// r.Methods("POST").Path("/profiles/{id}/addresses/")
r := request.(postAddressRequest)
profileID := url.QueryEscape(r.ProfileID)
req.Method, req.URL.Path = "POST", "/profiles/"+profileID+"/addresses/"
req.URL.Path = "/profiles/" + profileID + "/addresses/"
return encodeRequest(ctx, req, request)
}

Expand All @@ -283,7 +283,7 @@ func encodeDeleteAddressRequest(ctx context.Context, req *http.Request, request
r := request.(deleteAddressRequest)
profileID := url.QueryEscape(r.ProfileID)
addressID := url.QueryEscape(r.AddressID)
req.Method, req.URL.Path = "DELETE", "/profiles/"+profileID+"/addresses/"+addressID
req.URL.Path = "/profiles/" + profileID + "/addresses/" + addressID
return encodeRequest(ctx, req, request)
}

Expand Down