use batch values API for CloudWatch PutMetric data call#960
use batch values API for CloudWatch PutMetric data call#960peterbourgon merged 3 commits intogo-kit:masterfrom
Conversation
|
Yup, sorry. |
|
@peterbourgon hey, fixing the tests took some effort and changes. |
|
@cam-stitt This is your package :D Feedback? @trane9991 Did you see package cloudwatch2? Should this be ported there, too? |
|
hmmm... I see that cloudwatch2 uses the |
cam-stitt
left a comment
There was a problem hiding this comment.
I like the implementation, but I think we can just tidy it a little and always use the batch request.
| }) | ||
| } | ||
|
|
||
| if len(values) == 0 { |
There was a problem hiding this comment.
We could move this above the datum initialization to save an alloc, but not a big deal.
|
Nice, thanks! |
Some time ago, AWS introduced the way to publish a batch of metric values in one call.
So there is no point in sending
last(values)if we could send the whole batch.This PR implements the sending of values batch,